From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: the war on trailing whitespace Date: Sun, 26 Feb 2006 15:26:17 -0500 Message-ID: <20060226202617.GH7851@redhat.com> References: <20060225174047.0e9a6d29.akpm@osdl.org> <7v1wxq7psj.fsf@assigned-by-dhcp.cox.net> <20060225210712.29b30f59.akpm@osdl.org> <20060226103604.2d97696c.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , junkio@cox.net, git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun Feb 26 21:26:53 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FDSTj-00035u-47 for gcvg-git@gmane.org; Sun, 26 Feb 2006 21:26:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbWBZU0s (ORCPT ); Sun, 26 Feb 2006 15:26:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751144AbWBZU0s (ORCPT ); Sun, 26 Feb 2006 15:26:48 -0500 Received: from mx1.redhat.com ([66.187.233.31]:54957 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751043AbWBZU0r (ORCPT ); Sun, 26 Feb 2006 15:26:47 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1QKQWMZ031807; Sun, 26 Feb 2006 15:26:32 -0500 Received: from nwo.kernelslacker.org (vpn83-121.boston.redhat.com [172.16.83.121]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1QKQR128671; Sun, 26 Feb 2006 15:26:27 -0500 Received: from nwo.kernelslacker.org (localhost.localdomain [127.0.0.1]) by nwo.kernelslacker.org (8.13.5/8.13.5) with ESMTP id k1QKQM0A018166; Sun, 26 Feb 2006 15:26:22 -0500 Received: (from davej@localhost) by nwo.kernelslacker.org (8.13.5/8.13.5/Submit) id k1QKQHSJ018164; Sun, 26 Feb 2006 15:26:17 -0500 X-Authentication-Warning: nwo.kernelslacker.org: davej set sender to davej@redhat.com using -f To: Linus Torvalds Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Feb 26, 2006 at 12:16:25PM -0800, Linus Torvalds wrote: > Few enough people run "git-apply" on its own. Most people (certainly me) > end up using it through some email-applicator script or other. So the plan > was that the --whitespace=warn/error flag would go there, and that > git-apply by default would work more like "patch". > > But hey, I have no strong preferences, and it's easy enough to make the > default be warn (and add a "--whitespace=ok" flag to turn it off). > > Personally, I don't mind whitespace that much. In particular, I _suspect_ > I often have empty lines like > > int i; > > i = 10; > > where the "empty" line actually has the same indentation as the lines > around it. Is that wrong? Perhaps. I think I have the same anal-retentive problem Andrew has, because I have .. highlight RedundantSpaces term=standout ctermbg=red guibg=red match RedundantSpaces /\s\+$\| \+\ze\t/ in my .vimrc, which highlights this (and other trailing whitespace) as a big red blob. I do this in part for the same reason Andrew does, so that when someone sends me a diff with a zillion spaces at the EOL, it screams at me, I spot them, and chop them out. Dave