Git development
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@hp.com>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Don't use excessive non-standard border width
Date: Tue, 28 Feb 2006 10:46:11 +0530	[thread overview]
Message-ID: <20060228051611.GB5934@satan.india.hp.com> (raw)
In-Reply-To: <20060228045631.21880.27670.stgit@dv.roinet.com>

On Mon, Feb 27, 2006 at 11:56:31PM -0500, Pavel Roskin wrote:
> From: Pavel Roskin <proski@gnu.org>
> 
> 
> ---
> 
>  contrib/gitview/gitview |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
> index aded7ed..00cb8ee 100755
> --- a/contrib/gitview/gitview
> +++ b/contrib/gitview/gitview
> @@ -492,7 +492,6 @@ class GitView:
>  	def construct_top(self):
>  		"""Construct the top-half of the window."""
>  		vbox = gtk.VBox(spacing=6)
> -		vbox.set_border_width(12)
>  		vbox.show()
>  
>  		menu_bar = gtk.MenuBar()
> @@ -574,7 +573,6 @@ class GitView:
>  	def construct_bottom(self):
>  		"""Construct the bottom half of the window."""
>  		vbox = gtk.VBox(False, spacing=6)
> -		vbox.set_border_width(12)
>  		(width, height) = self.window.get_size()
>  		vbox.set_size_request(width, int(height / 2.5))
>  		vbox.show()


I am not sure about this. I guess it looks much better with a border.

Not applied.

-aneesh

  parent reply	other threads:[~2006-02-28  5:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060228045629.21880.19007.stgit@dv.roinet.com>
2006-02-28  5:15 ` [PATCH 1/2] Use solid text for refs in gitview Aneesh Kumar K.V
     [not found] ` <20060228045631.21880.27670.stgit@dv.roinet.com>
2006-02-28  5:16   ` Aneesh Kumar K.V [this message]
2006-02-28  5:35     ` [PATCH 2/2] Don't use excessive non-standard border width Pavel Roskin
2006-02-28  5:53       ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060228051611.GB5934@satan.india.hp.com \
    --to=aneesh.kumar@hp.com \
    --cc=git@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox