From: Fredrik Kuivinen <freku045@student.liu.se>
To: Junio C Hamano <junkio@cox.net>
Cc: Fredrik Kuivinen <freku045@student.liu.se>, git@vger.kernel.org
Subject: Re: [PATCH 0/3] Teach git-blame about renames
Date: Thu, 9 Mar 2006 08:30:14 +0100 [thread overview]
Message-ID: <20060309073014.GA1500@c165.ib.student.liu.se> (raw)
In-Reply-To: <7v4q28h38p.fsf@assigned-by-dhcp.cox.net>
On Wed, Mar 08, 2006 at 04:27:02PM -0800, Junio C Hamano wrote:
> > -static int compare_tree(struct tree *t1, struct tree *t2)
> > +int compare_tree(struct tree *t1, struct tree *t2)
> > ...
> > -static int same_tree_as_empty(struct tree *t1)
> > +int same_tree_as_empty(struct tree *t1)
>
> Maybe the names are a bit too generic to be used as a global?
>
Yes.. maybe. They are quite general though. Any suggestions for better
names? We could prefix everything in revision.h with "rev_" or
something like that.
Thanks for the comments. I will send an updated patch series soon.
- Fredrik
prev parent reply other threads:[~2006-03-09 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 22:54 [PATCH 0/3] Teach git-blame about renames Fredrik Kuivinen
2006-03-08 22:59 ` [PATCH 1/3] Make it possible to not clobber object.util in sort_in_topological_order Fredrik Kuivinen
2006-03-08 22:59 ` [PATCH 2/3] rev-lib: Make it easy to do rename tracking Fredrik Kuivinen
2006-03-08 23:00 ` [PATCH 3/3] blame: Rename detection Fredrik Kuivinen
2006-03-09 0:27 ` [PATCH 0/3] Teach git-blame about renames Junio C Hamano
2006-03-09 7:30 ` Fredrik Kuivinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309073014.GA1500@c165.ib.student.liu.se \
--to=freku045@student.liu.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).