From: Petr Baudis <pasky@suse.cz>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Don't use merge labels in the ed scripts
Date: Tue, 21 Mar 2006 22:48:18 +0100 [thread overview]
Message-ID: <20060321214818.GY19263@pasky.or.cz> (raw)
In-Reply-To: <1142977465.8712.4.camel@dv>
Hi,
Dear diary, on Tue, Mar 21, 2006 at 10:44:25PM CET, I got a letter
where Pavel Roskin <proski@gnu.org> said that...
> On Tue, 2006-03-21 at 21:59 +0100, Petr Baudis wrote:
> > Dear diary, on Tue, Mar 21, 2006 at 09:54:14PM CET, I got a letter
> > where Pavel Roskin <proski@gnu.org> said that...
> > > From: Pavel Roskin <proski@gnu.org>
> > >
> > > Merge labels keep changing, and they are not required to identify
> > > specific lines uniquely for the test purposes.
> > >
> > > Signed-off-by: Pavel Roskin <proski@gnu.org>
> >
> > Well, I sincerely hope that they won't change again. ;-)
>
> Actually, it would be nice to never expose labels starting with
> ".merge_file_" - cogito should provide more meaningful labels instead.
we shouldn't ever expose them, though. If we do, that's a bug.
> If you prefer, I'll submit a minimal patch to 0017-alice-bob-fixup.ed
> instead. Once ".merge_file_" is gone, the "tutorial" testsuite would
> check that such labels never appear again.
Curious, it contains the old-style label yet does not fail here now.
Unfortunately I have no time to play with it now. :-( A patch will be
most welcome.
Thanks,
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time. I think
I have forgotten this before.
next prev parent reply other threads:[~2006-03-21 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 20:54 [PATCH] Don't use merge labels in the ed scripts Pavel Roskin
2006-03-21 20:59 ` Petr Baudis
2006-03-21 21:44 ` Pavel Roskin
2006-03-21 21:48 ` Petr Baudis [this message]
2006-03-22 4:07 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060321214818.GY19263@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).