git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: Jon Loeliger <jdl@jdl.com>, git@vger.kernel.org
Subject: Re: [RFC] Silent File Mods Being Committed
Date: Thu, 23 Mar 2006 22:47:10 +0100	[thread overview]
Message-ID: <20060323214710.GV18185@pasky.or.cz> (raw)
In-Reply-To: <7vek0t68we.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Thu, Mar 23, 2006 at 06:13:21AM CET, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
>  (2) audit all the scripts to make sure they do not get upset if
>      we add trailing +/- to the status letter, and do that
>      unconditionally, like the attached patch does.

Cogito will get upset since we assume the mode field is one-char in our
regexps, and when we don't, we compare the mode field with strings and
that would obviously fail if you add random stuff to it.

Otherwise, I like this idea, though.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.

  reply	other threads:[~2006-03-23 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-23  4:04 [RFC] Silent File Mods Being Committed Jon Loeliger
2006-03-23  5:13 ` Junio C Hamano
2006-03-23 21:47   ` Petr Baudis [this message]
2006-03-23 23:32     ` Junio C Hamano
2006-03-23 23:32     ` Junio C Hamano
2006-03-24  1:12       ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060323214710.GV18185@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=jdl@jdl.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).