From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] cogito: Avoid slowness when timewarping large trees.
Date: Fri, 24 Mar 2006 05:55:44 -0500 [thread overview]
Message-ID: <20060324105543.GA2543@coredump.intra.peff.net> (raw)
In-Reply-To: <7vd5gc16u2.fsf@assigned-by-dhcp.cox.net>
On Fri, Mar 24, 2006 at 02:21:25AM -0800, Junio C Hamano wrote:
> Metainformation fields are internally separated with SP and a
> TAB comes before pathname; you can just say:
>
> sed -ne 's/^:[^ ]* D //p'
That is much cleaner (I stupidly just converted the original regex
verbatim).
> a SP). You might also want to consider "xargs rm -f --", BTW.
Oops, you're right. In particular, rm complains when there are no
deletions.
> However, I wonder why it does not do this instead:
>
> ... stash away the local changes
> git-read-tree -m "$base" ;# reset the index to $base
>
> # switch to $branch -- removing gone files as well
> git-read-tree -m -u "$base" "$branch"
>
> Then you can also lose diff-tree and checkout-index there.
This doesn't deal very well with local changes. The second read-tree
complains about a not uptodate entry during the merge. Since we've
already stashed the local changes as a diff, we should be able to simply
ignore them during the read-tree. Should the first read-tree actually
be:
git-read-tree --reset "$base"
?
-Peff
next prev parent reply other threads:[~2006-03-24 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 8:44 [PATCH] cogito: Avoid slowness when timewarping large trees Jeff King
2006-03-24 10:21 ` Junio C Hamano
2006-03-24 10:55 ` Jeff King [this message]
2006-03-24 11:01 ` Junio C Hamano
2006-03-24 11:22 ` Jeff King
2006-03-24 16:43 ` Shawn Pearce
2006-03-25 9:36 ` Jeff King
2006-03-25 9:39 ` [PATCH] " Jeff King
2006-03-26 18:05 ` Petr Baudis
2006-03-25 19:55 ` [PATCH] cogito: " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324105543.GA2543@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).