[BUG] gitk draws a wrong line

[BUG] gitk draws a wrong line

[Uwe Zeisberger]

Hallo,

I'm using 1.3.0.rc4.g2855d in Linus Linux tree. When doing

	$ gitk v2.6.16..v2.6.17-rc1

and then going to commit 10c2df65060e1ab57b2f75e0749de0ee9b8f4810, 
I see a small superfluous line between the two commits under 10c2df.

But still worse, if I select the line going down from 10c2df and then
select it's parent (i.e c76b6b) I get a big line ending in the commit
descriptions and four lines ending in midair.

See screenshots at 

	http://www.informatik.uni-freiburg.de/~zeisberg/bug-gitk/

Best regards
Uwe

-- 
Uwe Zeisberger

cat /*dev/null; echo 'Hello World!';
cat > /dev/null <<*/ 
() { } int main() { printf("Hello World!\n");}
/* */

Re: [BUG] gitk draws a wrong line

[Paul Mackerras]

Uwe Zeisberger writes:

> and then going to commit 10c2df65060e1ab57b2f75e0749de0ee9b8f4810, 
> I see a small superfluous line between the two commits under 10c2df.
> 
> But still worse, if I select the line going down from 10c2df and then
> select it's parent (i.e c76b6b) I get a big line ending in the commit
> descriptions and four lines ending in midair.

That is an X server bug, it seems.  Tk already clips vertices that it
sends to the X server to be within a box that is no more than 32000
pixels wide or high, but that seems not to be enough with some X
servers.  What X server version are you using and what sort of video
card?

If you're feeling adventurous, you can rebuild Tk with the patch below
(courtesy of D. Richard Hipp) and see if that fixes it.  If it does it
proves that it is an X server bug.

Paul.

--- tkCanvUtil.c.orig   2006-02-08 08:51:31.859761208 -0500
+++ tkCanvUtil.c        2006-02-08 08:57:11.744090936 -0500
@@ -1657,25 +1657,27 @@
 
     /*
     ** Constrain all vertices of the path to be within a box that is no
-    ** larger than 32000 pixels wide or height.  The top-left corner of
+    ** larger than 16000 pixels wide or height.  The top-left corner of
     ** this clipping box is 1000 pixels above and to the left of the top
     ** left corner of the window on which the canvas is displayed.
     **
     ** This means that a canvas will not display properly on a canvas
-    ** window that is larger than 31000 pixels wide or high.  That is no
+    ** window that is larger than 14000 pixels wide or high.  That is no
     ** a problem today, but might someday become a factor for ultra-high
     ** resolutions displays.
     **
     ** The X11 protocol allows us (in theory) to expand the size of the
     ** clipping box to 32767 pixels.  But we have found experimentally that
-    ** XFree86 sometimes fails to draw lines correctly if they are longe
-    ** than about 32500 pixels.  So we have left a little margin in the
-    ** size to mask that bug.
+    ** XFree86 has problems with sizes bigger than 32500 pixels and we
+    ** have received reports of other X servers running in to trouble
+    ** at around 29000 pixels.  So we are going to play it safe a limit
+    ** pixel values to 14 bytes: 16384.  That is still sufficient for
+    ** a 4x4 ft display at 300 dpi.
     */
     lft = canvPtr->xOrigin - 1000.0;
     top = canvPtr->yOrigin - 1000.0;
-    rgh = lft + 32000.0;
-    btm = top + 32000.0;
+    rgh = lft + 16383.0;
+    btm = top + 16383.0;
 
     /* Try the common case first - no clipping.  Loop over the input
     ** coordinates and translate them into appropriate output coordinates.

Re: [BUG] gitk draws a wrong line

[Uwe Zeisberger]

Hello Paul,

Paul Mackerras wrote:
> Uwe Zeisberger writes:
> 
> > and then going to commit 10c2df65060e1ab57b2f75e0749de0ee9b8f4810, 
> > I see a small superfluous line between the two commits under 10c2df.
> > 
> > But still worse, if I select the line going down from 10c2df and then
> > select it's parent (i.e c76b6b) I get a big line ending in the commit
> > descriptions and four lines ending in midair.
> 
> That is an X server bug, it seems.  Tk already clips vertices that it
> sends to the X server to be within a box that is no more than 32000
> pixels wide or high, but that seems not to be enough with some X
> servers.  What X server version are you using and what sort of video
> card?
It's a Debian system with XFree 4.3.0.dfsg.1-14 and according to lspci I
have

	0000:01:00.0 VGA compatible controller: ATI Technologies Inc Radeon RV100 QY [Radeon 7000/VE]

> If you're feeling adventurous, you can rebuild Tk with the patch below
> (courtesy of D. Richard Hipp) and see if that fixes it.  If it does it
> proves that it is an X server bug.
OK, I tried that and it helped. 

I list my steps for people who want to "fix" it, too:

	Note: You need a deb-src line in your sources.list.  Moreover
	some packages are assumed to be installed (e.g. devscripts,
	fakeroot, vim :-))

	~$ mkdir src; cd src
	~/src$ apt-get build-dep tk8.4
	~/src$ apt-get source tk8.4
	~/src$ cd tk8.4-8.4.12
	~/src/tk8.4-8.4.12$ vim generic/tkCanvUtil.c

	[ apply the patch provided by Paul/D. Richard Hipp ]

	~/src/tk8.4-8.4.12$ dch -n

	[ write a sensible changelog entry ]

	~/src/tk8.4-8.4.12$ fakeroot dpkg-buildpackage
	...

	~/src/tk8.4-8.4.12$ cd ..
	~/src$ sudo dpkg -i tk8.4_8.4.12-1.1_i386.deb

I'm not entirely clear what this patch does.  From only reading it, I
assume it should only have an effect on rather big windows, right?

Do you know some more details about the bug?  Do you know to who it
should get reported?

Thanks for your help
Uwe

-- 
Uwe Zeisberger

http://www.google.com/search?q=gravity+on+earth%3D