* [PATCH] Fix filename scaling for binary files
@ 2006-04-18 21:26 Jonas Fonseca
0 siblings, 0 replies; only message in thread
From: Jonas Fonseca @ 2006-04-18 21:26 UTC (permalink / raw)
To: Junio C Hamano, Git Mailing List
Set maximum filename length for binary files so that scaling won't be
triggered and result in invalid string access.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
diff.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/diff.c b/diff.c
index b54bbfa..ddcfb84 100644
--- a/diff.c
+++ b/diff.c
@@ -250,13 +250,14 @@ static void show_stats(struct diffstat_t
for (i = 0; i < data->nr; i++) {
struct diffstat_file *file = data->files[i];
+ len = strlen(file->name);
+ if (max_len < len)
+ max_len = len;
+
if (file->is_binary || file->is_unmerged)
continue;
if (max_change < file->added + file->deleted)
max_change = file->added + file->deleted;
- len = strlen(file->name);
- if (max_len < len)
- max_len = len;
}
for (i = 0; i < data->nr; i++) {
--
Jonas Fonseca
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-18 21:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-18 21:26 [PATCH] Fix filename scaling for binary files Jonas Fonseca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).