git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: [BUG] gitk draws a wrong line
Date: Tue, 25 Apr 2006 09:54:29 +0200	[thread overview]
Message-ID: <20060425075429.GA1532@informatik.uni-freiburg.de> (raw)
In-Reply-To: <17485.31716.452326.229628@cargo.ozlabs.ibm.com>

Hello Paul,

Paul Mackerras wrote:
> Uwe Zeisberger writes:
> 
> > and then going to commit 10c2df65060e1ab57b2f75e0749de0ee9b8f4810, 
> > I see a small superfluous line between the two commits under 10c2df.
> > 
> > But still worse, if I select the line going down from 10c2df and then
> > select it's parent (i.e c76b6b) I get a big line ending in the commit
> > descriptions and four lines ending in midair.
> 
> That is an X server bug, it seems.  Tk already clips vertices that it
> sends to the X server to be within a box that is no more than 32000
> pixels wide or high, but that seems not to be enough with some X
> servers.  What X server version are you using and what sort of video
> card?
It's a Debian system with XFree 4.3.0.dfsg.1-14 and according to lspci I
have

	0000:01:00.0 VGA compatible controller: ATI Technologies Inc Radeon RV100 QY [Radeon 7000/VE]

> If you're feeling adventurous, you can rebuild Tk with the patch below
> (courtesy of D. Richard Hipp) and see if that fixes it.  If it does it
> proves that it is an X server bug.
OK, I tried that and it helped. 

I list my steps for people who want to "fix" it, too:

	Note: You need a deb-src line in your sources.list.  Moreover
	some packages are assumed to be installed (e.g. devscripts,
	fakeroot, vim :-))

	~$ mkdir src; cd src
	~/src$ apt-get build-dep tk8.4
	~/src$ apt-get source tk8.4
	~/src$ cd tk8.4-8.4.12
	~/src/tk8.4-8.4.12$ vim generic/tkCanvUtil.c

	[ apply the patch provided by Paul/D. Richard Hipp ]

	~/src/tk8.4-8.4.12$ dch -n

	[ write a sensible changelog entry ]

	~/src/tk8.4-8.4.12$ fakeroot dpkg-buildpackage
	...

	~/src/tk8.4-8.4.12$ cd ..
	~/src$ sudo dpkg -i tk8.4_8.4.12-1.1_i386.deb

I'm not entirely clear what this patch does.  From only reading it, I
assume it should only have an effect on rather big windows, right?

Do you know some more details about the bug?  Do you know to who it
should get reported?

Thanks for your help
Uwe

-- 
Uwe Zeisberger

http://www.google.com/search?q=gravity+on+earth%3D

      reply	other threads:[~2006-04-25  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 10:40 [BUG] gitk draws a wrong line Uwe Zeisberger
2006-04-25  1:31 ` Paul Mackerras
2006-04-25  7:54   ` Uwe Zeisberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060425075429.GA1532@informatik.uni-freiburg.de \
    --to=zeisberg@informatik.uni-freiburg.de \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).