From: Shawn Pearce <spearce@spearce.org>
To: Junio Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] Automatically line wrap long commit messages.
Date: Mon, 29 May 2006 04:57:39 -0400 [thread overview]
Message-ID: <20060529085738.GB29500@spearce.org> (raw)
When using -m on the command line with git-commit it is not uncommon
for a long commit message to be entered without line terminators.
This creates commit objects whose messages are not readable in
'git log' as the line runs off the screen.
So instead reformat log messages if they are supplied on the
command line.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
This one might cause some problems for people. It requires
'fmt' in order to use log messages on the command line as well as
some users may not like having their log messages line wrapped.
I'm open to suggestions for how to deal with this but personally
this is one feature which I put into pg's commit tool that I miss
dearly when working with core GIT.
git-commit.sh | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/git-commit.sh b/git-commit.sh
index a092b72..e7aa4b1 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -547,7 +547,12 @@ fi
if test "$log_message" != ''
then
- echo "$log_message"
+ # The message came from the command line. It might contain very
+ # long lines so reformat it with a target of 60. Note that we
+ # don't reformat messages created in an editor by the user as
+ # we should assume they carefully formatted it in some way.
+ #
+ echo "$log_message" | fmt -w 60
elif test "$logfile" != ""
then
if test "$logfile" = -
--
1.3.3.g45d8
next reply other threads:[~2006-05-29 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 8:57 Shawn Pearce [this message]
2006-05-29 9:00 ` [PATCH] Automatically line wrap long commit messages Jan-Benedict Glaw
2006-05-29 9:14 ` Shawn Pearce
2006-05-29 9:16 ` Junio C Hamano
2006-05-29 9:46 ` Shawn Pearce
2006-05-30 8:38 ` Junio C Hamano
2006-05-31 2:18 ` Shawn Pearce
2006-05-31 5:05 ` Junio C Hamano
2006-06-01 3:34 ` Shawn Pearce
2006-06-01 6:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060529085738.GB29500@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).