git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Junio Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Automatically line wrap long commit messages.
Date: Mon, 29 May 2006 05:14:23 -0400	[thread overview]
Message-ID: <20060529091423.GD29500@spearce.org> (raw)
In-Reply-To: <20060529090045.GW13513@lug-owl.de>

Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Mon, 2006-05-29 04:57:39 -0400, Shawn Pearce <spearce@spearce.org> wrote:
> > When using -m on the command line with git-commit it is not uncommon
> > for a long commit message to be entered without line terminators.
> > This creates commit objects whose messages are not readable in
> > 'git log' as the line runs off the screen.
> 
> Uh? Just put it in quotes and press the Enter key when applicable.

I realize that.  But I feel that it looks rather ugly on the command
line, in the resulting message, and is difficult to do well all of
the time.

For one thing the first line is offset due to the stuff preeceding
it on the command line, even if you put the -m" on the next line.
For another it goes nicely with my prior patch of allowing multiple
-m flags on the command line and merging them into a single commit
message by treating each option argument as its own paragraph.

Maybe its just me but I've generally found `fmt` does a nice job
of line wrapping my text.  I'm writing this email out in vi with
no thought to line wrapping and will let `fmt` clean it all up for
me before I sent it.  I do the same thing with all of my commit
messages; except git-commit won't let me do it from the command line.

This patch was trying to do that...  but I suspected some folks
would not like the idea very much.  :-)

-- 
Shawn.

  reply	other threads:[~2006-05-29  9:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-29  8:57 [PATCH] Automatically line wrap long commit messages Shawn Pearce
2006-05-29  9:00 ` Jan-Benedict Glaw
2006-05-29  9:14   ` Shawn Pearce [this message]
2006-05-29  9:16 ` Junio C Hamano
2006-05-29  9:46   ` Shawn Pearce
2006-05-30  8:38     ` Junio C Hamano
2006-05-31  2:18       ` Shawn Pearce
2006-05-31  5:05         ` Junio C Hamano
2006-06-01  3:34           ` Shawn Pearce
2006-06-01  6:37             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060529091423.GD29500@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=jbglaw@lug-owl.de \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).