Git development
 help / color / mirror / Atom feed
From: Ryan Anderson <ryan@michonline.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Ryan Anderson <rda@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.
Date: Tue, 30 May 2006 01:51:26 -0700	[thread overview]
Message-ID: <20060530085125.GB32457@h4x0r5.com> (raw)
In-Reply-To: <7v8xok3vhj.fsf@assigned-by-dhcp.cox.net>

On Mon, May 29, 2006 at 10:57:44PM -0700, Junio C Hamano wrote:
> Ryan Anderson <rda@google.com> writes:
> 
> > Signed-off-by: Ryan Anderson <rda@google.com>
> >
> > ---
> >
> > 64ea8c0210c2e9d1711a870460eca326778a4ffc
> >  t/t9001-send-email.sh |   34 ++++++++++++++++++++++++++++++++++
> >  1 files changed, 34 insertions(+), 0 deletions(-)
> >  create mode 100755 t/t9001-send-email.sh
> 
> Adds test, alright, but I do not see the fix.  Is this a thinko?

I apparently screwed this patch up (and I think I lost it, in the
process.)

Let me reconstruct, I fixed the problems in a different way (I reworked
unique_email_address(@) into  unique_email_address($@), to pass a flag
stating whether to returned the cleaned email address or not, that
should come in a few minutes.)

      parent reply	other threads:[~2006-05-30  8:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11489310153730-git-send-email-1>
     [not found] ` <11489310153598-git-send-email-1>
     [not found]   ` <11489310151293-git-send-email-1>
     [not found]     ` <11489310153617-git-send-email-1>
2006-05-30  5:57       ` [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered Junio C Hamano
2006-05-30  6:45         ` Junio C Hamano
2006-05-30  6:58           ` Junio C Hamano
2006-05-30 13:23             ` Alex Riesen
2006-05-30 15:21               ` Christopher Faylor
2006-05-30 16:00                 ` Alex Riesen
2006-05-30 17:03                   ` Christopher Faylor
2006-05-30 17:08                   ` Ryan Anderson
2006-05-30 17:32                     ` Alex Riesen
2006-05-30  8:51         ` Ryan Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060530085125.GB32457@h4x0r5.com \
    --to=ryan@michonline.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=rda@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox