git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/8] Make a couple of commands builtin
@ 2006-06-13 20:21 Lukas Sandström
  2006-06-13 21:54 ` Timo Hirvonen
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Sandström @ 2006-06-13 20:21 UTC (permalink / raw)
  To: Junio C Hamano, Git Mailing List; +Cc: Lukas Sandström

This patchseries has the ultimate goal of making
git-am a builtin.

The version of git-am I'm sending out makes quite heavy
use of system(), but I think that can be worked around.
I just haven't figured out how, yet.

/Lukas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/8] Make a couple of commands builtin
  2006-06-13 20:21 [PATCH 0/8] Make a couple of commands builtin Lukas Sandström
@ 2006-06-13 21:54 ` Timo Hirvonen
  2006-06-13 22:03   ` Lukas Sandström
  0 siblings, 1 reply; 3+ messages in thread
From: Timo Hirvonen @ 2006-06-13 21:54 UTC (permalink / raw)
  To: lukass; +Cc: junkio, git

Lukas Sandström <lukass@etek.chalmers.se> wrote:

> This patchseries has the ultimate goal of making
> git-am a builtin.
> 
> The version of git-am I'm sending out makes quite heavy
> use of system(), but I think that can be worked around.
> I just haven't figured out how, yet.

I don't think git-stripspace needs to be a built-in.  It doesn't even
depend on git.  It is just a tiny helper program used by git-am,
git-applymbox, git-commit and git-tag.  If all these commands are made
built-in then git-stripspace becomes useless.

-- 
http://onion.dynserv.net/~timo/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/8] Make a couple of commands builtin
  2006-06-13 21:54 ` Timo Hirvonen
@ 2006-06-13 22:03   ` Lukas Sandström
  0 siblings, 0 replies; 3+ messages in thread
From: Lukas Sandström @ 2006-06-13 22:03 UTC (permalink / raw)
  To: Timo Hirvonen; +Cc: junkio, git, Lukas Sandström

Timo Hirvonen wrote:
> Lukas Sandström <lukass@etek.chalmers.se> wrote:
> 
>> This patchseries has the ultimate goal of making
>> git-am a builtin.
>>
>> The version of git-am I'm sending out makes quite heavy
>> use of system(), but I think that can be worked around.
>> I just haven't figured out how, yet.
> 
> I don't think git-stripspace needs to be a built-in.  It doesn't even
> depend on git.  It is just a tiny helper program used by git-am,
> git-applymbox, git-commit and git-tag.  If all these commands are made
> built-in then git-stripspace becomes useless.
> 

The reason I made it builtin was to de able to call it easily from git-am.

As you say, once all the users are builtin it could be removed, unless somone
is using it in their scripts.

/Lukas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-06-13 22:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-13 20:21 [PATCH 0/8] Make a couple of commands builtin Lukas Sandström
2006-06-13 21:54 ` Timo Hirvonen
2006-06-13 22:03   ` Lukas Sandström

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).