From: Petr Baudis <pasky@suse.cz>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: What's in git.git and announcing v1.4.1-rc1
Date: Thu, 22 Jun 2006 22:58:59 +0200 [thread overview]
Message-ID: <20060622205859.GF21864@pasky.or.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0606221301500.5498@g5.osdl.org>
Dear diary, on Thu, Jun 22, 2006 at 10:53:31PM CEST, I got a letter
where Linus Torvalds <torvalds@osdl.org> said that...
> So in order to avoid a lot of blind git users, please apply this patch.
Great, since this also seems to make git diff more or less consistent
with cg diff in the colors choice.
> enum color_diff {
> - DIFF_PLAIN = 0,
> - DIFF_METAINFO = 1,
> - DIFF_FILE_OLD = 2,
> - DIFF_FILE_NEW = 3,
> + DIFF_RESET = 0,
> + DIFF_PLAIN = 1,
> + DIFF_METAINFO = 2,
> + DIFF_FRAGINFO = 3,
> + DIFF_FILE_OLD = 4,
> + DIFF_FILE_NEW = 5,
> };
Isn't manually numbering the enum choices somewhat pointless, though?
(Actually makes it more difficult to do changes in it later.)
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.
next prev parent reply other threads:[~2006-06-22 20:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 19:49 What's in git.git and announcing v1.4.1-rc1 Junio C Hamano
2006-06-22 20:16 ` Junio C Hamano
2006-06-22 20:21 ` Paolo Ciarrocchi
2006-06-22 20:53 ` Linus Torvalds
2006-06-22 20:58 ` Petr Baudis [this message]
2006-06-22 21:02 ` Linus Torvalds
2006-06-22 21:24 ` Jakub Narebski
2006-06-22 21:28 ` Petr Baudis
2006-06-23 11:10 ` Johannes Schindelin
2006-06-22 22:07 ` Junio C Hamano
2006-06-22 22:38 ` Junio C Hamano
2006-06-23 11:10 ` Johannes Schindelin
2006-06-23 14:04 ` Pádraig Brady
2006-06-23 14:25 ` Johannes Schindelin
2006-06-23 14:59 ` Linus Torvalds
2006-06-24 11:12 ` [PATCH] diff --color: use $GIT_DIR/config Junio C Hamano
2006-06-24 19:44 ` Johannes Schindelin
2006-06-24 11:23 ` [PATCH] diff --color: use reset sequence when we mean reset Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060622205859.GF21864@pasky.or.cz \
--to=pasky@suse.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).