git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dennis Stosberg <dennis@stosberg.net>
To: Junio C Hamano <junkio@cox.net>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: [PATCH] "test" in Solaris' /bin/sh does not support -e
Date: Mon, 26 Jun 2006 10:27:54 +0200	[thread overview]
Message-ID: <20060626082754.G6ec0a61e@leonov.stosberg.net> (raw)
In-Reply-To: <20060626082428.G52c9608e@leonov.stosberg.net>

Running "make clean" currently fails:
  [ ! -e perl/Makefile ] || make -C perl/ clean
  /bin/sh: test: argument expected
  make: *** [clean] Error 1
---

Pasky said in #git that a simple -f test would suffice.

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 3dc54fe..d41d224 100644
--- a/Makefile
+++ b/Makefile
@@ -761,7 +761,7 @@ clean:
 	rm -f $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
 	rm -f $(htmldocs).tar.gz $(manpages).tar.gz
 	$(MAKE) -C Documentation/ clean
-	[ ! -e perl/Makefile ] || $(MAKE) -C perl/ clean || $(MAKE) -C perl/ clean
+	[ ! -f perl/Makefile ] || $(MAKE) -C perl/ clean || $(MAKE) -C perl/ clean
 	$(MAKE) -C templates/ clean
 	$(MAKE) -C t/ clean
 	rm -f GIT-VERSION-FILE GIT-CFLAGS
--
1.4.0

  parent reply	other threads:[~2006-06-26  8:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-25  1:47 [PATCH] Git.pm: Support for perl/ being built by a different compiler Petr Baudis
2006-06-25  3:14 ` Junio C Hamano
2006-06-25 15:27   ` Petr Baudis
2006-06-26  8:24   ` Dennis Stosberg
2006-06-26  8:26     ` [PATCH] Solaris needs inclusion of signal.h for signal() Dennis Stosberg
2006-06-26  8:27     ` [PATCH] Fix pkt-line.h to compile with a non-GCC compiler Dennis Stosberg
2006-06-26  8:27     ` Dennis Stosberg [this message]
2006-06-26  9:19       ` [PATCH] "test" in Solaris' /bin/sh does not support -e Junio C Hamano
2006-06-26  9:42         ` Dennis Stosberg
2006-06-26 10:04           ` Dennis Stosberg
2006-06-26 17:03             ` Junio C Hamano
2006-06-26 22:21               ` [PATCH] Makefile fix for Solaris Dennis Stosberg
2006-06-26 22:23               ` [PATCH] Add possibility to pass CFLAGS and LDFLAGS specific to the perl subdir Dennis Stosberg
2006-07-01 22:59                 ` Petr Baudis
2006-06-26 22:25               ` [PATCH] "test" in Solaris' /bin/sh does not support -e Dennis Stosberg
2006-06-26  8:29     ` [PATCH] Git.pm: Support for perl/ being built by a different compiler Dennis Stosberg
2006-06-26  8:51       ` Thomas Glanzmann
2006-06-26  9:26     ` Junio C Hamano
2006-06-26  9:32       ` Dennis Stosberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626082754.G6ec0a61e@leonov.stosberg.net \
    --to=dennis@stosberg.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).