From: Jeff King <peff@peff.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC] Cache negative delta pairs
Date: Thu, 29 Jun 2006 00:09:59 -0400 [thread overview]
Message-ID: <20060629040959.GA32156@coredump.intra.peff.net> (raw)
In-Reply-To: <7v4py4y7wo.fsf@assigned-by-dhcp.cox.net>
On Wed, Jun 28, 2006 at 08:09:43PM -0700, Junio C Hamano wrote:
> that hit your the negative cache are? That is, in find_deltas()
> function, we have "while (--j > 0)" loop that attempts to delta
> with the entry that is j (modulo window size) entries away from
> the current one, then j-1, j-2, ...; I am interested in the
> distribution of "j" value for the pair "n,m" that hits your
> negative cache for normal repositories, and I am speculating
> that the value would probably be small relative to the delta
> window size.
Just to make sure I am understanding you correctly, you're interested in
the distribution of 'j' each time we skip a delta for being negative
(or each time we mark a negative, but that should simply equal the
lookup times for the next run). The instrumentation I added simply
prints the value of j each time we skip a delta. The counts are
surprisingly uniform (this is for linux-2.6):
57209 j=1
57213 j=2
57217 j=3
57221 j=4
57225 j=5
57229 j=6
57233 j=7
57237 j=8
57241 j=9
57245 j=10
They're so uniform (and in order by j!) that I feel like I must have done
something wrong...
-Peff
next prev parent reply other threads:[~2006-06-29 4:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060628223744.GA24421@coredump.intra.peff.net>
2006-06-29 3:09 ` [RFC] Cache negative delta pairs Junio C Hamano
2006-06-29 3:50 ` Jeff King
2006-06-29 3:58 ` Jeff King
2006-06-29 4:30 ` Jeff King
2006-06-29 16:39 ` Nicolas Pitre
2006-06-29 18:07 ` Jeff King
2006-06-29 18:48 ` Nicolas Pitre
2006-06-29 18:58 ` Jeff King
2006-06-29 19:06 ` Nicolas Pitre
2006-06-29 4:09 ` Jeff King [this message]
2006-06-29 15:42 ` Nicolas Pitre
2006-06-29 16:35 ` Nicolas Pitre
2006-06-29 18:00 ` Jeff King
2006-06-29 18:24 ` Nicolas Pitre
2006-06-29 18:53 ` Jeff King
2006-06-29 19:04 ` Nicolas Pitre
2006-06-29 19:52 ` Jeff King
2006-06-29 20:24 ` Nicolas Pitre
2006-06-29 21:04 ` Linus Torvalds
2006-06-29 21:24 ` Nicolas Pitre
2006-06-29 21:30 ` Linus Torvalds
2006-06-29 21:39 ` Jeff King
2006-06-29 21:43 ` Joel Becker
2006-06-29 21:47 ` Nicolas Pitre
2006-06-29 22:12 ` Junio C Hamano
2006-06-30 3:44 ` [PATCH] consider previous pack undeltified object state only when reusing delta data Nicolas Pitre
2006-06-30 9:45 ` Johannes Schindelin
2006-06-30 12:28 ` Andreas Ericsson
2006-06-30 16:55 ` Nicolas Pitre
2006-07-03 8:11 ` Andreas Ericsson
2006-06-29 21:35 ` [RFC] Cache negative delta pairs Jeff King
2006-06-29 21:54 ` Junio C Hamano
2006-06-29 22:22 ` Junio C Hamano
2006-06-29 21:26 ` Junio C Hamano
2006-06-29 21:37 ` Jeff King
2006-06-29 22:31 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060629040959.GA32156@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).