From: Timo Hirvonen <tihirvon@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] Make git-fmt-merge-msg a builtin
Date: Mon, 3 Jul 2006 19:16:35 +0300 [thread overview]
Message-ID: <20060703191635.21ba0af3.tihirvon@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0607031731550.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > > free(NULL) is safe.
> > >
> > > Is it? I vaguely remember that I had problems with this on some obscure
> > > platform.
> >
> > I don't think so.
>
> Well, after a little Googling, I am more convinced than ever that it is a
> BAD thing to rely on free(NULL) being a NOP.
I did some research too. Seems that C89 requires free(NULL) to be a
no-op but on some old systems (SunOS) it may crash. IMNSHO these
systems were designed to crash valid programs and torture developers.
There are probably many free(NULL) and realloc(NULL, ...) uses in the
git source code and are not worth fixing.
--
http://onion.dynserv.net/~timo/
next prev parent reply other threads:[~2006-07-03 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 13:31 [PATCH] Make git-fmt-merge-msg a builtin Johannes Schindelin
2006-07-03 14:17 ` Timo Hirvonen
2006-07-03 14:36 ` Johannes Schindelin
2006-07-03 15:26 ` Timo Hirvonen
2006-07-03 15:45 ` Johannes Schindelin
2006-07-03 16:16 ` Timo Hirvonen [this message]
2006-07-03 21:29 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060703191635.21ba0af3.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).