git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Waitz <tali@admingilde.org>
To: git@vger.kernel.org
Subject: comparing file contents in is_exact_match?
Date: Thu, 6 Jul 2006 07:57:29 +0200	[thread overview]
Message-ID: <20060706055729.GA12512@admingilde.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

hoi :)

I created a git repository for my photo collection and then renamed
some photos (about 600).  Now git status and commit get hit by
the OOM killer.

The reason for that is that is_exact_match (in diffcore-rename.c) maps
both the source and destination file into memory and then compares them
byte for byte.  This is a little bit too much for my little machine.

When I remove the content comparation and only leave the sha1
comparision, then my renames are correctly found in a second.  But
unluckily, some other renames in the testcases are not correctly
handled any more.

So is there an easy solution?  Why is the content comparision in
is_exact_match needed?

-- 
Martin Waitz

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2006-07-06  5:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06  5:57 Martin Waitz [this message]
2006-07-06  6:20 ` comparing file contents in is_exact_match? Junio C Hamano
2006-07-06  7:16   ` Martin Waitz
2006-07-06  7:33     ` Junio C Hamano
2006-07-06  7:41       ` Martin Waitz
2006-07-06 17:55       ` Martin Waitz
2006-07-07 16:33 ` Florian Weimer
2006-07-08  2:50   ` Johannes Schindelin
2006-07-16  9:05     ` Florian Weimer
2006-07-16 14:00       ` Johannes Schindelin
2006-07-16 15:03       ` Yakov Lerner
2006-07-16 22:36         ` Alex Riesen
2006-07-17  5:25           ` Florian Weimer
2006-07-17 12:41             ` Johannes Schindelin
2006-07-17 15:43               ` Linus Torvalds
2006-07-17 16:05                 ` Johannes Schindelin
2006-07-17 17:56                   ` Linus Torvalds
2006-07-17 18:15                     ` Martin Waitz
2006-07-17 20:20                     ` Alex Riesen
2006-07-17 19:37                   ` Geert Bosch
2006-07-17 21:31                     ` Linus Torvalds
2006-07-18  9:38                       ` Yakov Lerner
2006-07-18 10:20                         ` Johannes Schindelin
2006-07-18 15:37                         ` Linus Torvalds
2006-07-18 18:49                           ` Alex Riesen
2006-07-17 16:32               ` Juergen Ruehle
2006-07-17 17:10                 ` Johannes Schindelin
2006-07-17 17:37                   ` Juergen Ruehle
2006-07-17 20:32                 ` Yakov Lerner
2006-07-17 22:43                   ` Juergen Ruehle
2006-07-18  9:15                     ` Yakov Lerner
2006-07-17 12:11           ` Yakov Lerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060706055729.GA12512@admingilde.org \
    --to=tali@admingilde.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).