From: Dennis Stosberg <dennis@stosberg.net>
To: git@vger.kernel.org
Subject: [PATCH 4/4] configure: Fixes for Solaris
Date: Fri, 07 Jul 2006 18:26:44 +0200 [thread overview]
Message-ID: <20060707162644.25746.78865.stgit@leonov.stosberg.net> (raw)
In-Reply-To: <20060707162513.25746.57374.stgit@leonov.stosberg.net>
From: Dennis Stosberg <dennis@stosberg.net>
- Solaris' /bin/sh will not find a function if there is a variable
with the same name.
- 'test -z $var' fails if $var is empty. Needs to be 'test -z "$var"'
Signed-off-by: Dennis Stosberg <dennis@stosberg.net>
---
config-lib.sh | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/config-lib.sh b/config-lib.sh
index 0bcd4c3..4dd4d00 100755
--- a/config-lib.sh
+++ b/config-lib.sh
@@ -181,7 +181,7 @@ add_library() { # --with
lib_help="$lib_help
$desc [$hdefault]"
switches="$switches switch_lib \"$name\" \"$switch\" \"\$ac_option\" || "
- mkvars="$mkvars mkvar \"\$$name\" \"$mkvar\";"
+ mkvars="$mkvars print_mkvar \"\$$name\" \"$mkvar\";"
eval "$name=$default"
}
@@ -196,7 +196,7 @@ add_feature() { # --enable
feature_help="$feature_help
$desc [$hdefault]"
switches="$switches switch_feature \"$name\" \"$switch\" \"\$ac_option\" || "
- mkvars="$mkvars mkvar \"\$$name\" \"$mkvar\";"
+ mkvars="$mkvars print_mkvar \"\$$name\" \"$mkvar\";"
eval "$name=$default"
}
@@ -226,7 +226,7 @@ switch_feature() {
return 0
}
-mkvar() {
+print_mkvar() {
value="$1"; shift; mkvar="$1"; shift
noval=""; yesval="ConfigureYesPlease"
case $mkvar in
@@ -533,15 +533,15 @@ PERL_PATH = $_perl
INSTALL = $_install
EOF
- test -z $_prefix || echo "prefix = $_prefix"
- test -z $_bindir || echo "bindir = $_bindir"
- test -z $_gitexecdir || echo "gitexecdir = $_gitexecdir"
- test -z $_mandir || ( echo "mandir = $_mandir" && echo "export mandir" )
- test -z $_templatedir || echo "template_dir = $_templatedir"
- test -z $_gitpythondir || echo "GIT_PYTHON_DIR = $_gitpythondir"
-
- test -z $_python || echo "PYTHON_PATH = $_python"
- test -z $_no_python || echo "NO_PYTHON = $_no_python"
+ test -z "$_prefix" || echo "prefix = $_prefix"
+ test -z "$_bindir" || echo "bindir = $_bindir"
+ test -z "$_gitexecdir" || echo "gitexecdir = $_gitexecdir"
+ test -z "$_mandir" || ( echo "mandir = $_mandir" && echo "export mandir" )
+ test -z "$_templatedir" || echo "template_dir = $_templatedir"
+ test -z "$_gitpythondir" || echo "GIT_PYTHON_DIR = $_gitpythondir"
+
+ test -z "$_python" || echo "PYTHON_PATH = $_python"
+ test -z "$_no_python" || echo "NO_PYTHON = $_no_python"
echo
eval "$mkvars"
next prev parent reply other threads:[~2006-07-07 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 16:25 [PATCH 0/4] More tests for hand-written configure (resend) Dennis Stosberg
2006-07-07 16:26 ` [PATCH 1/4] configure: Add test for Perl Dennis Stosberg
2006-07-07 16:26 ` [PATCH 2/4] configure: Add test for Python Dennis Stosberg
2006-07-07 16:26 ` [PATCH 3/4] configure: Try to figure out compiler options Dennis Stosberg
2006-07-07 16:26 ` Dennis Stosberg [this message]
2006-07-07 19:40 ` [PATCH 0/4] More tests for hand-written configure (resend) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707162644.25746.78865.stgit@leonov.stosberg.net \
--to=dennis@stosberg.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox