git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tar-tree: add the "tar.applyUmask" config option
Date: Thu, 20 Jul 2006 00:50:21 +0200	[thread overview]
Message-ID: <20060719225021.GA28591@1wt.eu> (raw)
In-Reply-To: <7vd5c1jkc3.fsf@assigned-by-dhcp.cox.net>

On Wed, Jul 19, 2006 at 03:33:48PM -0700, Junio C Hamano wrote:
> Willy Tarreau <w@1wt.eu> writes:
> 
> > While I agreed with Linus that the very permissive file modes set in tar
> > archives were not particularly a problem for kernel users, I'm finding
> > that for some other projects it sometimes becomes really annoying, to
> > the point that I finally considered using a plain tar instead. This is a
> > shame because tar-tree is really fast an powerful, and I like its ability
> > to enforce permissions when those of the local dir might be wrong for
> > various reasons.
> 
> I do not have problem with an option to allow a non-default
> behaviour in this area.  Maybe we might want to be able to set
> the mask in the configuration file as well, perhaps like...
> 
> 	tar.umask = user ;# use from the current process'
>         tar.umask = 0    ;# same as default
>         tar.umask = 002  ;# group friendly

This is an excellent idea. I will try to find some spare time tomorrow
to implement it. I've also seen the proposal about the --umask= option.
I don't think it's absolutely necessary since the umask has little reason
to change during the repo's life, but if the implementation is obvious,
I will do it too.

Thanks for your suggestion,
Willy

  reply	other threads:[~2006-07-19 22:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-19 21:40 [PATCH] tar-tree: add the "tar.applyUmask" config option Willy Tarreau
2006-07-19 22:33 ` Junio C Hamano
2006-07-19 22:50   ` Willy Tarreau [this message]
2006-07-20  9:30   ` Willy Tarreau
2006-07-20  9:44     ` Rogan Dawes
2006-07-20  9:55       ` Willy Tarreau
2006-07-19 22:39 ` Johannes Schindelin
2006-07-20  8:14 ` Rene Scharfe
2006-07-24  6:42   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060719225021.GA28591@1wt.eu \
    --to=w@1wt.eu \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).