Git development
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] gitweb: fix two warnings
Date: Wed, 26 Jul 2006 10:48:41 -0700 (PDT)	[thread overview]
Message-ID: <20060726174841.90834.qmail@web31809.mail.mud.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0607261658130.29667@wbgn013.biozentrum.uni-wuerzburg.de>

--- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> These warnings cluttered up my log.
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>  gitweb/gitweb.cgi |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
> index e226ac2..e5fca63 100755
> --- a/gitweb/gitweb.cgi
> +++ b/gitweb/gitweb.cgi
> @@ -795,7 +795,7 @@ sub git_read_projects {
>  	if (-d $projects_list) {
>  		# search in directory
>  		my $dir = $projects_list;
> -		opendir my $dh, $dir or return undef;
> +		opendir my ($dh), $dir or return undef;
>  		while (my $dir = readdir($dh)) {
>  			if (-e "$projectroot/$dir/HEAD") {
>  				my $pr = {
> @@ -810,7 +810,7 @@ sub git_read_projects {
>  		# 'git%2Fgit.git Linus+Torvalds'
>  		# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'
>  		# 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'
> -		open my $fd , $projects_list or return undef;
> +		open my ($fd), $projects_list or return undef;
>  		while (my $line = <$fd>) {
>  			chomp $line;
>  			my ($path, $owner) = split ' ', $line;
> -- 
> 1.4.2.rc2.g6a4e

Can you please give more details of the warnings, cut-and-paste
would be nice, the problem as you perceive it, and your solution to it?

Thanks,
   Luben

  reply	other threads:[~2006-07-26 17:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-26 14:58 [PATCH] gitweb: fix two warnings Johannes Schindelin
2006-07-26 17:48 ` Luben Tuikov [this message]
2006-07-26 18:43   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060726174841.90834.qmail@web31809.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox