From: Eric Wong <normalperson@yhbt.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL
Date: Wed, 26 Jul 2006 15:40:50 -0700 [thread overview]
Message-ID: <20060726224049.GA16645@localdomain> (raw)
In-Reply-To: <Pine.LNX.4.63.0607261634200.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
> git-instaweb.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 242b55e..340ab98 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -245,4 +245,5 @@ esac
>
> start_httpd
> test -z "$browser" && browser=echo
> +which "$browser" >/dev/null 2>&1 || browser=echo
> $browser http://127.0.0.1:$port
>From what I hear, 'which' isn't portable on some platforms.
Now this isn't the only place 'which' is used in instaweb, and I've been
meaning to get rid of the other 'which' call in there for a while, but I
haven't had much time to devote to git the past few weeks. Help here
would be good.
--
Eric Wong
next prev parent reply other threads:[~2006-07-26 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 14:34 [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL Johannes Schindelin
2006-07-26 22:40 ` Eric Wong [this message]
2006-07-27 1:12 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726224049.GA16645@localdomain \
--to=normalperson@yhbt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).