* [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL
@ 2006-07-26 14:34 Johannes Schindelin
2006-07-26 22:40 ` Eric Wong
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2006-07-26 14:34 UTC (permalink / raw)
To: git, junkio, Eric Wong
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
git-instaweb.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 242b55e..340ab98 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -245,4 +245,5 @@ esac
start_httpd
test -z "$browser" && browser=echo
+which "$browser" >/dev/null 2>&1 || browser=echo
$browser http://127.0.0.1:$port
--
1.4.2.rc2.g6a4e
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL
2006-07-26 14:34 [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL Johannes Schindelin
@ 2006-07-26 22:40 ` Eric Wong
2006-07-27 1:12 ` Eric Wong
0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2006-07-26 22:40 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, junkio
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
> git-instaweb.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 242b55e..340ab98 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -245,4 +245,5 @@ esac
>
> start_httpd
> test -z "$browser" && browser=echo
> +which "$browser" >/dev/null 2>&1 || browser=echo
> $browser http://127.0.0.1:$port
>From what I hear, 'which' isn't portable on some platforms.
Now this isn't the only place 'which' is used in instaweb, and I've been
meaning to get rid of the other 'which' call in there for a while, but I
haven't had much time to devote to git the past few weeks. Help here
would be good.
--
Eric Wong
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-27 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-26 14:34 [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL Johannes Schindelin
2006-07-26 22:40 ` Eric Wong
2006-07-27 1:12 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).