From: Shawn Pearce <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, Alex Riesen <raa.lkml@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: print errors from git-update-ref
Date: Fri, 28 Jul 2006 02:27:20 -0400 [thread overview]
Message-ID: <20060728062720.GC30783@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0607271302150.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Wed, 26 Jul 2006, Shawn Pearce wrote:
>
> > This change adds a test for trying to create a ref within a directory
> > that is actually currently a file, and adds error printing within
> > the ref locking routine should the resolve operation fail.
>
> Why not just print an error message when the resolve operation fails,
> instead of special casing this obscure corner case? It is way shorter,
> too. The test should stay, though.
Did you read the patch? If resolve_ref returns NULL then this
change prints an error (from errno) no matter what. If errno is
ENOTDIR then it tries to figure out what part of the ref path wasn't
a directory (but was attempted to be used as such) and prints an
ENOTDIR error about that path instead of the one actually given
to the ref lock function
So I think I'm doing what you are suggesting...
--
Shawn.
next prev parent reply other threads:[~2006-07-28 6:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 13:13 print errors from git-update-ref Alex Riesen
2006-07-24 6:06 ` Junio C Hamano
2006-07-27 1:28 ` Shawn Pearce
2006-07-27 11:04 ` Johannes Schindelin
2006-07-28 6:27 ` Shawn Pearce [this message]
2006-07-28 7:26 ` Junio C Hamano
2006-07-29 3:44 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728062720.GC30783@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).