From: Jeff King <peff@peff.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG
Date: Wed, 2 Aug 2006 16:41:54 -0400 [thread overview]
Message-ID: <20060802204154.GA15678@sigio.intra.peff.net> (raw)
In-Reply-To: <ear1fp$j9p$2@sea.gmane.org>
On Wed, Aug 02, 2006 at 10:21:43PM +0200, Jakub Narebski wrote:
> > @@ -56,7 +50,7 @@ # URI of GIT logo
> > our $logo = "@@GITWEB_LOGO@@";
> >
> > # source of projects list
> > -our $projects_list = "@@GITWEB_LIST@@" || "$projectroot";
> > +our $projects_list = "@@GITWEB_LIST@@";
> >
> > # default blob_plain mimetype and default charset for text/plain blob
> > our $default_blob_plain_mimetype = 'text/plain';
>
> But why that change?
Because the previous order was:
1. set projectroot to build-time default
2. set projects_list to build-time default or $projectroot
3. read variables, including $projectroot, from config file
If you kept $projects_list empty but set $projectroot in your config,
the value of projects_list would be the build-time $projectroot, not the
config-time. If you look further in the patch, you will see that we set
up projects_list later.
-Peff
next prev parent reply other threads:[~2006-08-02 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 19:23 [PATCH] gitweb: optionally read config from GITWEB_CONFIG Jeff King
2006-08-02 20:17 ` [PATCH] gitweb: use single quotes for values replaced by the Makefile Matthias Lederhofer
2006-08-02 20:50 ` Junio C Hamano
2006-08-02 20:57 ` Matthias Lederhofer
2006-08-02 20:58 ` Jeff King
2006-08-02 20:21 ` [PATCH] gitweb: optionally read config from GITWEB_CONFIG Jakub Narebski
2006-08-02 20:31 ` Matthias Lederhofer
2006-08-02 20:36 ` Jakub Narebski
2006-08-02 20:41 ` Jeff King [this message]
2006-08-02 20:28 ` Junio C Hamano
2006-08-02 20:29 ` [PATCH] gitweb: require $ENV{'GITWEB_CONFIG'} Matthias Lederhofer
2006-08-02 20:50 ` Jeff King
2006-08-02 20:58 ` Junio C Hamano
2006-08-02 20:59 ` Jeff King
2006-08-02 20:51 ` [PATCH] gitweb: optionally read config from GITWEB_CONFIG Luben Tuikov
2006-08-02 20:56 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802204154.GA15678@sigio.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox