git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Singer <elf@buici.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: gitweb testing with non-apache web server
Date: Thu, 3 Aug 2006 08:34:03 -0700	[thread overview]
Message-ID: <20060803153403.GA30729@buici.com> (raw)
In-Reply-To: <easbev$act$1@sea.gmane.org>

On Thu, Aug 03, 2006 at 10:18:07AM +0200, Jakub Narebski wrote:
> <opublikowany i wys?any>
> 
> Marc Singer wrote:
> 
> 
> > I did some debugging on the latest repo version.  The lines
> > 
> >   our $project = ($cgi->param('p') || $ENV{'PATH_INFO'});
> >   if (defined $project) {
> >      ...
> > 
> > are being executed even though the url is
> > 
> >   http://server/git
> > 
> > I think that the problem is that Cherokee translates the request URL
> > into
> > 
> >   http://server/git/
> > 
> > which means that the $ENV{'PATH_INFO'} is the string "/" insted of
> > being undefined.
> 
> Try changing
> 
> my $project = ($cgi->param('p') || $ENV{'PATH_INFO'});
> if (defined $project) {
>         $project =~ s|^/||; $project =~ s|/$||;
> 
> to
> 
> my $project = ($cgi->param('p') || $ENV{'PATH_INFO'});
> $project =~ s|^/||; $project =~ s|/$||;
> if (defined $project && $project) {     
> 
> (and send patch if it works, please).

That isn't enough.  I did something like that when I was exploring the
script.  While the change *does* eliminate the 403 error, it doesn't
make the rest of the script work properly.  All of the links return to
the same page that lists the projects.


> 
> -- 
> Jakub Narebski
> Warsaw, Poland
> ShadeHawk on #git
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2006-08-03 15:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-03  7:54 gitweb testing with non-apache web server Marc Singer
2006-08-03  8:18 ` Jakub Narebski
2006-08-03 15:34   ` Marc Singer [this message]
2006-08-03 15:48     ` Jakub Narebski
2006-08-03 16:20       ` Marc Singer
2006-08-03 18:21       ` Junio C Hamano
2006-08-03 18:37         ` Jakub Narebski
2006-08-03 19:41           ` Junio C Hamano
2006-08-03 20:14             ` Martin Waitz
2006-08-03 11:42 ` Sam Vilain
2006-08-03 15:56 ` Blu Corater
2006-08-03 16:22   ` Marc Singer
2006-08-03 19:21     ` Blu Corater
2006-08-03 20:27       ` Marc Singer
2006-08-03 23:55         ` Francis Daly
2006-08-04  6:11           ` Marc Singer
2006-08-04 19:48             ` Francis Daly
2006-08-04  7:30           ` Marc Singer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060803153403.GA30729@buici.com \
    --to=elf@buici.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).