From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-status: colorize status output
Date: Sat, 5 Aug 2006 19:42:40 -0400 [thread overview]
Message-ID: <20060805234240.GA11545@coredump.intra.peff.net> (raw)
In-Reply-To: <20060805203107.GB16186@moooo.ath.cx> <20060805202759.GA16186@moooo.ath.cx>
On Sat, Aug 05, 2006 at 10:27:59PM +0200, Matthias Lederhofer wrote:
> I would suggest that all scripts that use colors have a
> always/auto/never (with boolean fallback) option and also honor
> pager.color if the pager is in use.
I'll send out a patch in a moment.
> I don't see the case where git-status and git status behave
> differently (except for git -p status but git-status does not have an
> option for paging at all).
Sorry, I didn't say what I meant at all. My problem was that one
cannot get color with a pager using git-status (by doing
'git-status | less'). The output is not a tty, but GIT_PAGER_IN_USE is
not set (and of course I cannot use '-p'). However, that is a moot point
with always/auto/never, since in such a case I can just use 'always'.
-Peff
next prev parent reply other threads:[~2006-08-05 23:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-05 3:14 [PATCH] git-status: colorize status output Jeff King
2006-08-05 3:21 ` Jeff King
2006-08-05 8:16 ` Greg KH
2006-08-05 9:28 ` Junio C Hamano
2006-08-05 10:21 ` Jeff King
2006-08-05 10:44 ` Jeff King
2006-08-05 10:59 ` Matthias Lederhofer
2006-08-05 11:21 ` Junio C Hamano
2006-08-05 11:27 ` Junio C Hamano
2006-08-05 11:28 ` Matthias Lederhofer
2006-08-05 11:42 ` Junio C Hamano
2006-08-05 12:18 ` Matthias Lederhofer
2006-08-05 19:54 ` Jeff King
2006-08-05 20:31 ` Matthias Lederhofer
2006-08-05 19:51 ` Jeff King
2006-08-07 17:12 ` Sam Ravnborg
2006-08-05 19:45 ` Jeff King
2006-08-05 20:27 ` Matthias Lederhofer
2006-08-05 23:42 ` Jeff King [this message]
2006-08-06 5:01 ` Joel Becker
2006-08-06 6:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060805234240.GA11545@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).