From: Willy Tarreau <w@1wt.eu>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: What's in git.git, and announcing GIT 1.4.2-rc4
Date: Thu, 10 Aug 2006 07:42:11 +0200 [thread overview]
Message-ID: <20060810054211.GA28387@1wt.eu> (raw)
In-Reply-To: <7vfyg5xi02.fsf@assigned-by-dhcp.cox.net>
On Wed, Aug 09, 2006 at 10:43:57PM -0700, Junio C Hamano wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
> > Willy Tarreau <w@1wt.eu> writes:
> >
> >> I encountered a problem in 1.4.1 and 1.4-git about 2 weeks ago
> >> (I've not tried 1.4.2-rc4 yet). When applying a git patch which
> >> contains a symlink, the symlink created on the filesystem sometimes
> >> has a wrong name with some chars appended to its end.
> >
> > Thanks. I can reproduce this, and am looking into it.
>
> Found it. The patch application mechanism uses a counted string
> (char *buf with ulong size) to hold the result, and the code
> stupidly threw the buf to symlink(2), without making it NUL
> terminated.
Excellent ! That means that under some circumstances, it might even have
corrupted the very first link, and not necessarily only the second and
other ones. Thanks for having fixed it that fast.
Cheers,
Willy
next prev parent reply other threads:[~2006-08-10 5:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 1:29 What's in git.git, and announcing GIT 1.4.2-rc4 Junio C Hamano
2006-08-10 3:34 ` Willy Tarreau
2006-08-10 5:05 ` Junio C Hamano
2006-08-10 5:43 ` Junio C Hamano
2006-08-10 5:42 ` Willy Tarreau [this message]
2006-08-10 7:47 ` Johannes Schindelin
2006-08-10 7:59 ` Junio C Hamano
2006-08-10 8:05 ` Johannes Schindelin
2006-08-10 8:10 ` Junio C Hamano
2006-08-10 8:19 ` Junio C Hamano
2006-08-10 8:27 ` Johannes Schindelin
2006-08-10 13:34 ` Alex Riesen
2006-08-10 14:00 ` Johannes Schindelin
2006-08-10 14:30 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810054211.GA28387@1wt.eu \
--to=w@1wt.eu \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).