From: Jeff King <peff@peff.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: diff machinery cleanup
Date: Thu, 10 Aug 2006 16:10:50 -0400 [thread overview]
Message-ID: <20060810201049.GA4759@sigio.intra.peff.net> (raw)
In-Reply-To: <7vzmecv7tp.fsf@assigned-by-dhcp.cox.net>
On Thu, Aug 10, 2006 at 10:06:42AM -0700, Junio C Hamano wrote:
> No, run_diff_index munges the index in-core, and it does not
> writes it out for obvious reasons.
Ah, OK, that makes more sense. Is there any reason then that this
wouldn't work (it certainly seems to, but I don't want to be causing
invisible problems that will come back later)? You seemed to outline a
much more complex procedure in your original mail.
run_diff_index();
discard_cache();
...
run_diff_files();
I'd like to go with this simple solution at first for the C runstatus,
and then hopefully move to simultaneous diffing later.
-Peff
next prev parent reply other threads:[~2006-08-10 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 8:24 diff machinery cleanup Jeff King
2006-08-10 9:36 ` Junio C Hamano
2006-08-10 10:38 ` Jeff King
2006-08-10 17:06 ` Junio C Hamano
2006-08-10 20:10 ` Jeff King [this message]
2006-08-10 21:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810201049.GA4759@sigio.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).