From: Fredrik Kuivinen <freku045@student.liu.se>
To: git@vger.kernel.org
Subject: git-mv is broken in master
Date: Tue, 15 Aug 2006 22:51:50 +0200 [thread overview]
Message-ID: <20060815205150.GA467@c165.ib.student.liu.se> (raw)
Hi,
With the current master I get the following:
$ git-mv README README-renamed
fatal: can not move directory into itself, source=README, destination=README-renamed
Which is buggy. The culprit seems to be the test
if (!bad &&
!strncmp(destination[i], source[i], strlen(source[i])))
bad = "can not move directory into itself";
at line ~207 in builtin-mv.c.
If the source isn't a prefix of the destination things works as expected,
$ git mv README renamed-README
$
- Fredrik
next reply other threads:[~2006-08-15 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 20:51 Fredrik Kuivinen [this message]
2006-08-15 21:02 ` git-mv is broken in master David Rientjes
2006-08-16 0:20 ` [PATCH] git-mv: succeed even if source is a prefix of destination Johannes Schindelin
2006-08-16 5:49 ` Fredrik Kuivinen
2006-08-16 6:34 ` Johannes Schindelin
2006-08-16 8:44 ` Johannes Schindelin
2006-08-16 19:22 ` Fredrik Kuivinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815205150.GA467@c165.ib.student.liu.se \
--to=freku045@student.liu.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).