From: Jonas Fonseca <fonseca@diku.dk>
To: David Rientjes <rientjes@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] make inline is_null_sha1 global
Date: Tue, 15 Aug 2006 23:58:12 +0200 [thread overview]
Message-ID: <20060815215812.GB15797@diku.dk> (raw)
In-Reply-To: <Pine.LNX.4.63.0608151335020.1475@chino.corp.google.com>
David Rientjes <rientjes@google.com> wrote Tue, Aug 15, 2006:
> diff --git a/builtin-diff.c b/builtin-diff.c
> index 82afce7..9003d55 100644
> --- a/builtin-diff.c
> +++ b/builtin-diff.c
> @@ -68,8 +68,7 @@ static void stuff_change(struct diff_opt
> {
> struct diff_filespec *one, *two;
>
> - if (memcmp(null_sha1, old_sha1, 20) &&
> - memcmp(null_sha1, new_sha1, 20) &&
> + if (is_null_sha1(old_sha1) && is_null_sha1(new_sha1) &&
> !memcmp(old_sha1, new_sha1, 20))
> return;
>
Looks like this should be !is_null_sha1(...) in both cases.
--
Jonas Fonseca
next prev parent reply other threads:[~2006-08-15 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 20:37 [PATCH] make inline is_null_sha1 global David Rientjes
2006-08-15 21:58 ` Jonas Fonseca [this message]
2006-08-15 22:11 ` David Rientjes
2006-08-15 22:28 ` Jonas Fonseca
2006-08-16 6:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815215812.GB15797@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).