From: Fredrik Kuivinen <freku045@student.liu.se>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Fredrik Kuivinen <freku045@student.liu.se>,
David Rientjes <rientjes@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-mv: succeed even if source is a prefix of destination
Date: Wed, 16 Aug 2006 21:22:54 +0200 [thread overview]
Message-ID: <20060816192254.GA9575@c165.ib.student.liu.se> (raw)
In-Reply-To: <Pine.LNX.4.63.0608161041300.28360@wbgn013.biozentrum.uni-wuerzburg.de>
On Wed, Aug 16, 2006 at 10:44:02AM +0200, Johannes Schindelin wrote:
> >
> > It looks like we need some kind of path normalization before we do
> > those tests.
>
> I kind of hoped it was not necessary to do this, since get_pathspec() does
> a rudimentary version of it (BTW git-mv.perl got it wrong: it substituted
> "./" by "", which would fail for a directory name like "endsWithADot.").
>
> It was a little more involved:
>
> -- 8< --
> [PATCH] git-mv: add more path normalization
>
> We already use the normalization from get_pathspec(), but now we also
> remove a trailing slash. So,
>
> git mv some_path/ into_some_path/
>
> works now.
>
> Also, move the "can not move directory into itself" test before the
> subdirectory expansion.
>
It works as expected now. Thanks!
- Fredrik
prev parent reply other threads:[~2006-08-16 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 20:51 git-mv is broken in master Fredrik Kuivinen
2006-08-15 21:02 ` David Rientjes
2006-08-16 0:20 ` [PATCH] git-mv: succeed even if source is a prefix of destination Johannes Schindelin
2006-08-16 5:49 ` Fredrik Kuivinen
2006-08-16 6:34 ` Johannes Schindelin
2006-08-16 8:44 ` Johannes Schindelin
2006-08-16 19:22 ` Fredrik Kuivinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060816192254.GA9575@c165.ib.student.liu.se \
--to=freku045@student.liu.se \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).