Re: [PATCH] gitweb: use common parameter parsing and generation for "o", too.

[Martin Waitz <tali@admingilde.org>]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

hoi :)

On Thu, Aug 17, 2006 at 11:35:18AM +0200, Jakub Narebski wrote:
> > The "o" (list order) parameter was handled special.
> > Now it is generated with the common href() function and parsed together with
> > all other parameters.
>  
> This was because "o" (sort table by) parameter was used only
> in one place, and valid values of order parameter depends on
> the place it is used.

But I'd really like to have all the parameter parsing and generation
code in one place.

Perhaps we can agree that only the validation should be coupled with the
actual user?  E.g. use normal validate_input() for it and then check
for actual values inside git_project_list (which is already done now).

-- 
Martin Waitz

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]