From: Luben Tuikov <ltuikov@yahoo.com>
To: git@vger.kernel.org
Subject: [PATCH] gitweb: bugfix: list regression
Date: Tue, 22 Aug 2006 01:55:40 -0700 (PDT) [thread overview]
Message-ID: <20060822085540.1104.qmail@web31812.mail.mud.yahoo.com> (raw)
Fix regression introduced by
commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.
1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines
"a.list" twice in gitweb.css, once with bold and once with
normal font-weight.
2. "a.list" being "bold", makes a myriad of things shown by
gitweb in bold font-weight, which is a regression from
pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.
The fix is to define separately "a.list_bold" and use
that style in format_subject_html().
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.css | 9 +++++++--
gitweb/gitweb.perl | 4 ++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 9013895..db58629 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -115,13 +115,18 @@ div.list_head {
font-style: italic;
}
-a.list {
+a.list_bold {
text-decoration: none;
font-weight: bold;
color: #000000;
}
-table.tags a.list {
+a.list {
+ text-decoration: none;
+ color: #000000;
+}
+
+table.tags {
font-weight: normal;
}
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 063735d..5237f25 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -504,11 +504,11 @@ sub format_subject_html {
$extra = '' unless defined($extra);
if (length($short) < length($long)) {
- return $cgi->a({-href => $href, -class => "list",
+ return $cgi->a({-href => $href, -class => "list_bold",
-title => $long},
esc_html($short) . $extra);
} else {
- return $cgi->a({-href => $href, -class => "list"},
+ return $cgi->a({-href => $href, -class => "list_bold"},
esc_html($long) . $extra);
}
}
--
1.4.2.g3851f
next reply other threads:[~2006-08-22 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 8:55 Luben Tuikov [this message]
2006-08-22 9:19 ` [PATCH] gitweb: bugfix: list regression Junio C Hamano
2006-08-22 9:30 ` Jakub Narebski
2006-08-22 10:02 ` [PATCH] gitweb: bugfix: a.list formatting regression Jakub Narebski
2006-08-22 22:34 ` Junio C Hamano
2006-08-22 22:46 ` Jakub Narebski
2006-08-22 23:14 ` Junio C Hamano
2006-08-23 4:43 ` Luben Tuikov
2006-08-23 4:45 ` Luben Tuikov
2006-08-23 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822085540.1104.qmail@web31812.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).