From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type
Date: Mon, 4 Sep 2006 18:13:48 +0200 [thread overview]
Message-ID: <200609041813.49103.jnareb@gmail.com> (raw)
In-Reply-To: <200609041810.09838.jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is my first post with binary patch. I'd rather not send file
git-favicon.png as an attachement due to filtering.
You can see (and download) the favicon istelf at
http://git.or.cz/gitwiki/GitRelatedLogos
(the first favicon).
Makefile | 2 ++
gitweb/git-favicon.png | Bin
gitweb/gitweb.perl | 5 +++++
3 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 199fbe8..f3b762d 100644
--- a/Makefile
+++ b/Makefile
@@ -137,6 +137,7 @@ GITWEB_LIST =
GITWEB_HOMETEXT = indextext.html
GITWEB_CSS = gitweb.css
GITWEB_LOGO = git-logo.png
+GITWEB_FAVICON = git-favicon.png
export prefix bindir gitexecdir template_dir GIT_PYTHON_DIR
@@ -674,6 +675,7 @@ gitweb/gitweb.cgi: gitweb/gitweb.perl
-e 's|++GITWEB_HOMETEXT++|$(GITWEB_HOMETEXT)|g' \
-e 's|++GITWEB_CSS++|$(GITWEB_CSS)|g' \
-e 's|++GITWEB_LOGO++|$(GITWEB_LOGO)|g' \
+ -e 's|++GITWEB_FAVICON++|$(GITWEB_FAVICON)|g' \
$< >$@+
chmod +x $@+
mv $@+ $@
diff --git a/gitweb/git-favicon.png b/gitweb/git-favicon.png
new file mode 100644
index 0000000..de637c0
Binary files /dev/null and b/gitweb/git-favicon.png differ
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7961945..bebaa0f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -48,6 +48,8 @@ # URI of default stylesheet
our $stylesheet = "++GITWEB_CSS++";
# URI of GIT logo
our $logo = "++GITWEB_LOGO++";
+# URI of GIT favicon, assumed to be image/png type
+our $favicon = "++GITWEB_FAVICON++";
# source of projects list
our $projects_list = "++GITWEB_LIST++";
@@ -1192,6 +1194,9 @@ EOF
'href="%s" type="application/rss+xml"/>'."\n",
esc_param($project), href(action=>"rss"));
}
+ if (defined $favicon) {
+ print qq(<link rel="shortcut icon" href="$favicon" type="image/png"/>\n);
+ }
print "</head>\n" .
"<body>\n" .
--
1.4.1.1
next prev parent reply other threads:[~2006-09-04 16:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 16:10 [PATCH 0/4] gitweb: Some improvements Jakub Narebski
2006-09-04 16:13 ` Jakub Narebski [this message]
2006-09-04 17:15 ` PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type Linus Torvalds
2006-09-04 18:32 ` [PATCH " Jakub Narebski
2006-09-04 18:34 ` Jakub Narebski
2006-09-04 22:46 ` Junio C Hamano
2006-09-04 23:00 ` Jakub Narebski
2006-09-04 23:17 ` Junio C Hamano
2006-09-04 16:15 ` [PATCH 2/4] gitweb: Change the name of diff to parent link in "commit" view to "diff" Jakub Narebski
2006-09-04 16:17 ` [PATCH 3/4] gitweb: Divide page path into directories -- path's "breadcrumbs" Jakub Narebski
2006-09-04 16:19 ` [PATCH 4/4] gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body Jakub Narebski
2006-09-04 23:22 ` [PATCH 0/4] gitweb: Some improvements Junio C Hamano
2006-09-04 23:53 ` Jakub Narebski
2006-09-05 8:59 ` gitweb testing and benchmarking (was: [PATCH 0/4] gitweb: Some improvements) Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609041813.49103.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).