From: "Fernando J. Pereda" <ferdy@gentoo.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What does "properly support iconv" in git Makefile (NO_ICONV) mean?
Date: Tue, 5 Sep 2006 01:16:09 +0200 [thread overview]
Message-ID: <20060904231609.GA6855@ferdyx.org> (raw)
In-Reply-To: <200609050108.57695.jnareb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On Tue, Sep 05, 2006 at 01:08:57AM +0200, Jakub Narebski wrote:
> To add autoconf support for checking if NO_ICONV has to be defined
> (Define NO_ICONV if your libc does not properly support iconv.)
> one needs to know what does "properly support iconv" mean.
>
> The commit message of a commit which introduced this compilation
> variable (commit b6e56eca8a4eb74a86e9f2d99aa480c665458aa7) tells:
>
> Systems using some uClibc versions do not properly support
> iconv stuff.
>
> At what exactly iconv fail? What should the test to put in configure.ac
> check?
As far as I know, iconv stuff is not supported on uClibc. Thats the
reason I sent the patch. Gentoo bug #115826 [1].
You should probably set it if you are building for uClibc. Not sure how
you'd test that in configure.ac though.
- ferdy
[1] https://bugs.gentoo.org/show_bug.cgi?id=115826
--
Fernando J. Pereda Garcimartín
Gentoo Developer (Alpha,net-mail,mutt,git)
20BB BDC3 761A 4781 E6ED ED0B 0A48 5B0C 60BD 28D4
[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]
next parent reply other threads:[~2006-09-04 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200609050108.57695.jnareb@gmail.com>
2006-09-04 23:16 ` Fernando J. Pereda [this message]
2006-09-04 23:26 ` What does "properly support iconv" in git Makefile (NO_ICONV) mean? Jakub Narebski
2006-09-04 23:31 ` Junio C Hamano
2006-09-04 23:41 ` Fernando J. Pereda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904231609.GA6855@ferdyx.org \
--to=ferdy@gentoo.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).