From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/5] autoconf: Preliminary check for working mmap
Date: Thu, 7 Sep 2006 01:58:04 -0400 [thread overview]
Message-ID: <20060907055803.GE31580@spearce.org> (raw)
In-Reply-To: <7vodtt8l6v.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Well, if you are talking about git.git t/ directory, I bet that
> "the full test suite" easily fits in a single window so much of
> the new code is not exercised, unless you have a runtime option
> to make use of very tiny window (32kB would be nice) for testing
> ;-).
Heh. t/ passed which meant basic rev listing and verify-pack
appeared OK. I hardcoded the window size to be 2*getpagesize() (8192
bytes on my Mac OS X system) and started beating up Git against its
own 8 MiB pack. The window code opened a ton of windows at once as
the PACK_MAX_SZ was 128 MiB. So I hardcoded that to be 16384 bytes.
And the code worked right against the 8 MiB Git pack by opening
only 4 windows at once and closing the least-recently-used one.
I can easily parameterize both values in .git/config; there's no
real reason for them to be hardcoded. That should make it easier
to craft some new test cases that push the windowing code.
> > I am going to rebase the changes to the 64 bit index in `pu`
> > and clean up my history. Its currently one massive commit with
> > lots of changes that should be broken down into slightly more
> > digestable chunks.
>
> Breaking things up would be nice. Do you have a good testcase
> out of Mozilla repository that _needs_ 64-bit index? The code
> in "pu" uses 64-bit index only 32-bit offset cannot describe the
> pack, so I only tested with an artificial case with the kernel
> archive with .idx converted with convert-idx to 64-bit.
>
Not really. We know the Mozilla pack decompressed is around 20 GiB.
I could decompress it and repack it using no deltas; that should
exceed 4 GiB. It will take quite some time to run the decompression
and delta inflates, especially with the highly-compressed 450 MiB
pack Jon Smirl sent me. I can do that kind of testing maybe later
next week after I get my new amd64 system built.
--
Shawn.
next prev parent reply other threads:[~2006-09-07 7:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 22:54 [PATCH 0/5] Some autoconf patches Jakub Narebski
2006-09-04 22:55 ` [PATCH 1/5] autoconf: Add some commented out variables to config.mak.in Jakub Narebski
2006-09-04 22:55 ` [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV Jakub Narebski
2006-09-05 16:25 ` Jonas Fonseca
2006-09-05 20:03 ` [PATCH] autoconf: Fix copy'n'paste error Jakub Narebski
2006-09-05 21:27 ` [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV Junio C Hamano
2006-09-04 22:56 ` [PATCH 3/5] autoconf: Preliminary check for working mmap Jakub Narebski
2006-09-04 23:36 ` Junio C Hamano
2006-09-04 23:43 ` Jakub Narebski
2006-09-05 3:09 ` Shawn Pearce
2006-09-05 5:10 ` Junio C Hamano
2006-09-05 6:25 ` Shawn Pearce
2006-09-05 7:43 ` Junio C Hamano
2006-09-06 3:40 ` Shawn Pearce
2006-09-06 7:17 ` Junio C Hamano
2006-09-06 8:15 ` Junio C Hamano
2006-09-07 5:58 ` Shawn Pearce [this message]
2006-09-04 22:57 ` [PATCH 4/5] autoconf: Check for subprocess.py Jakub Narebski
2006-09-04 22:58 ` [PATCH 5/5] autoconf: Quote AC_CACHE_CHECK arguments Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060907055803.GE31580@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).