From: Jeff King <peff@peff.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] Move color option parsing out of diff.c and into color.[ch]
Date: Thu, 7 Sep 2006 20:11:32 -0400 [thread overview]
Message-ID: <20060908001132.GA18649@coredump.intra.peff.net> (raw)
In-Reply-To: <7vfyf3s01w.fsf@assigned-by-dhcp.cox.net>
On Thu, Sep 07, 2006 at 04:56:43PM -0700, Junio C Hamano wrote:
> Some school of programming teach us to start the function name
> at the beginning of the line, separate from its type. They say
> that would make "grep '^parse_color'" to work better.
Hmm. I don't like that style either, I was just using it because I
thought that was the git style (which must have been caused by seeing
some other function(s) with the same style -- but grepping through, it
looks like there are very few functions using it). I'll fix the patches,
but will wait to resend until I hear other comments.
-Peff
prev parent reply other threads:[~2006-09-08 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2ec783f6a8e8a901f7c30947e8c0eb50f71bc185.1157610743.git.peff@peff.net>
2006-09-07 6:35 ` [PATCH 2/3] Move color option parsing out of diff.c and into color.[ch] Jeff King
2006-09-07 23:56 ` Junio C Hamano
2006-09-08 0:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060908001132.GA18649@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox