git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Art Haas" <ahaas@airmail.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: Re: Patch for http-fetch.c and older curl releases
Date: Tue, 19 Sep 2006 07:20:19 -0500	[thread overview]
Message-ID: <20060919122019.GA14835@artsapartment.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0609191027020.19042@wbgn013.biozentrum.uni-wuerzburg.de>

On Tue, Sep 19, 2006 at 10:31:12AM +0200, Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 18 Sep 2006, Art Haas wrote:
> 
> > +#if LIBCURL_VERSION_NUM < 0x070f05
> > +#define CURLE_HTTP_RETURNED_ERROR CURLE_HTTP_NOT_FOUND
> > +#endif
> 
> If you go to 
> 
> http://cool.haxx.se/cvs.cgi/curl/include/curl/curl.h?annotate=1.308
> 
> and search for HTTP_RETURNED_ERROR, it shows that revision "badger_1.180" 
> introduced it, which you can verify by clicking on the link to the diff. 
> This diff also says that the LIBCURL_VERSION_NUM (which is changed just 
> after a release in the curl project) is 0x70a03. Thus, you should check 
> for 0x70a03 instead of 0x70f05.

Hi.

Here's a patch that checks for that version of libcurl.

Signed-off-by: Art Haas <ahaas@airmail.net>

diff --git a/http.h b/http.h
index 9ca16ac..6e12e41 100644
--- a/http.h
+++ b/http.h
@@ -22,6 +22,10 @@ #if LIBCURL_VERSION_NUM < 0x070c04
 #define NO_CURL_EASY_DUPHANDLE
 #endif
 
+#if LIBCURL_VERSION_NUM < 0x070a03
+#define CURLE_HTTP_RETURNED_ERROR CURLE_HTTP_NOT_FOUND
+#endif
+
 struct slot_results
 {
 	CURLcode curl_result;

-- 
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822

      reply	other threads:[~2006-09-19 12:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-18 22:54 Patch for http-fetch.c and older curl releases Art Haas
2006-09-18 23:06 ` Junio C Hamano
2006-09-18 23:57   ` Art Haas
2006-09-19  0:14     ` Junio C Hamano
2006-09-19  0:32       ` Art Haas
2006-09-19  0:37         ` Junio C Hamano
2006-09-19  8:31     ` Johannes Schindelin
2006-09-19 12:20       ` Art Haas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060919122019.GA14835@artsapartment.org \
    --to=ahaas@airmail.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).