* [PATCH] gitweb: Fix thinko in git_tags and git_heads
@ 2006-09-19 18:47 Jakub Narebski
0 siblings, 0 replies; only message in thread
From: Jakub Narebski @ 2006-09-19 18:47 UTC (permalink / raw)
To: git
git_get_refs_list always return reference to list (and reference to
hash which we ignore), so $taglist (in git_tags) and $headlist (in
git_heads) are always defined, but @$taglist / @$headlist might be
empty. Replaced incorrect "if (defined @$taglist)" with
"if (@$taglist)" in git_tags and respectively in git_heads.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
gitweb/gitweb.perl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 34311ee..9445fa7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2565,7 +2565,7 @@ sub git_tags {
git_print_header_div('summary', $project);
my ($taglist) = git_get_refs_list("tags");
- if (defined @$taglist) {
+ if (@$taglist) {
git_tags_body($taglist);
}
git_footer_html();
@@ -2578,7 +2578,7 @@ sub git_heads {
git_print_header_div('summary', $project);
my ($headlist) = git_get_refs_list("heads");
- if (defined @$headlist) {
+ if (@$headlist) {
git_heads_body($headlist, $head);
}
git_footer_html();
--
1.4.2.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-09-19 19:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-19 18:47 [PATCH] gitweb: Fix thinko in git_tags and git_heads Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).