From: Petr Baudis <pasky@suse.cz>
To: git@vger.kernel.org
Subject: [PATCH] gitweb: Fix @git_base_url_list usage
Date: Wed, 20 Sep 2006 02:09:46 +0200 [thread overview]
Message-ID: <20060920000946.GC13132@pasky.or.cz> (raw)
As it is now, that array was never used because the customurl accessor was
broken and ''unless @url_list'' never happenned.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2d0d56f..1b029ac 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -731,7 +731,7 @@ sub git_get_project_description {
sub git_get_project_url_list {
my $path = shift;
- open my $fd, "$projectroot/$path/cloneurl" or return undef;
+ open my $fd, "$projectroot/$path/cloneurl" or return wantarray ? () : undef;
my @git_project_url_list = map { chomp; $_ } <$fd>;
close $fd;
next reply other threads:[~2006-09-20 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 0:09 Petr Baudis [this message]
2006-09-20 0:28 ` [PATCH] gitweb: Fix @git_base_url_list usage Junio C Hamano
2006-09-20 0:43 ` Junio C Hamano
2006-09-20 0:49 ` Petr Baudis
2006-09-22 23:15 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060920000946.GC13132@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).