git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Petr Baudis <pasky@suse.cz>,
	git@vger.kernel.org
Subject: Re: git pull for update of netdev fails.
Date: Wed, 20 Sep 2006 17:21:01 -0400	[thread overview]
Message-ID: <20060920212101.GA24415@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0609202304270.19042@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Another, even more serious problems with rebasing: You can introduce a bug 
> by rebasing. Meaning: git-rebase can succeed, even compilation is fine, 
> but the sum of your patches, and the patches you are rebasing on, is 
> buggy. And there is _no_ way to bisect this, since the "good" version can 
> be gone for good.

True, however one would hope that you tested the commit before you
rebased it and found it to working.  And bisect should point at the
new version of that commit as the break.  And then you can debug
it there.

I've seen this happen very rarely, and usually its an initialization
or calling order type of bug and its usually has more to do with 
other changes in the branch you are rebasing onto that aren't at the
side your patch affects.

Yes its something annoying to track down but certainly easy enough
with bisect, especially if you have relatively fine-grained commits
and a reasonably good test suite.

-- 
Shawn.

  reply	other threads:[~2006-09-20 21:23 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-20 15:03 git pull for update of netdev fails Stephen Hemminger
2006-09-20 15:28 ` Linus Torvalds
2006-09-20 15:54   ` Petr Baudis
2006-09-20 16:02     ` Johannes Schindelin
2006-09-20 16:07       ` Petr Baudis
2006-09-20 16:19         ` Linus Torvalds
2006-09-20 16:26           ` Linus Torvalds
2006-09-20 16:34             ` Shawn Pearce
2006-09-20 16:49               ` Linus Torvalds
2006-09-20 17:10                 ` Shawn Pearce
2006-09-20 21:23               ` Johannes Schindelin
2006-09-20 21:27                 ` Shawn Pearce
2006-09-20 21:37                   ` Johannes Schindelin
2006-09-20 21:42                     ` Junio C Hamano
2006-09-20 21:53                       ` Johannes Schindelin
2006-09-20 21:53                       ` Shawn Pearce
2006-09-20 21:49                     ` Shawn Pearce
2006-09-20 16:28           ` Shawn Pearce
2006-09-20 16:38             ` Linus Torvalds
2006-09-20 21:14           ` Johannes Schindelin
2006-09-20 21:21             ` Shawn Pearce [this message]
2006-09-20 21:27               ` Johannes Schindelin
2006-09-20 21:40                 ` Shawn Pearce
2006-09-20 22:34             ` Jakub Narebski
2006-09-23  3:44             ` Petr Baudis
2006-09-23  4:00               ` Shawn Pearce
2006-09-23  4:09                 ` Petr Baudis
2006-09-23 13:15                   ` Catalin Marinas
2006-09-23 13:10               ` Catalin Marinas
2006-09-24 20:54                 ` Petr Baudis
2006-09-25 12:47                   ` Catalin Marinas
2006-09-20 16:05     ` Junio C Hamano
2006-09-20 16:18       ` Petr Baudis
2006-09-20 16:33         ` Linus Torvalds
2006-09-20 20:01         ` Jakub Narebski
2006-09-20 16:15     ` Linus Torvalds
2006-09-20 16:59       ` Shawn Pearce
2006-09-20 17:34         ` Linus Torvalds
2006-09-20 23:12         ` Krzysztof Halasa
2006-09-23  4:18       ` Petr Baudis
2006-09-20 19:58     ` Jakub Narebski
2006-09-21  9:14       ` Johannes Schindelin
2006-09-20 19:24   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060920212101.GA24415@spearce.org \
    --to=spearce@spearce.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).