* [PATCH] gitweb: fix display of trees via PATH_INFO.
@ 2006-09-21 7:48 Martin Waitz
2006-09-21 8:56 ` Jakub Narebski
0 siblings, 1 reply; 2+ messages in thread
From: Martin Waitz @ 2006-09-21 7:48 UTC (permalink / raw)
To: git
When adding a / to the URL, git should display the corresponding
tree object, but it has to remove the / first.
Signed-off-by: Martin Waitz <tali@admingilde.org>
---
gitweb/gitweb.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index baadbe7..ea57717 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -300,6 +300,7 @@ sub evaluate_path_info {
$pathname =~ s,^/+,,;
if (!$pathname || substr($pathname, -1) eq "/") {
$action ||= "tree";
+ $pathname =~ s,/$,,;
} else {
$action ||= "blob_plain";
}
--
1.4.2.gb8b6b
--
Martin Waitz
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gitweb: fix display of trees via PATH_INFO.
2006-09-21 7:48 [PATCH] gitweb: fix display of trees via PATH_INFO Martin Waitz
@ 2006-09-21 8:56 ` Jakub Narebski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Narebski @ 2006-09-21 8:56 UTC (permalink / raw)
To: git
Martin Waitz wrote:
> When adding a / to the URL, git should display the corresponding
> tree object, but it has to remove the / first.
Hmm... I thought that gitweb works just fine with file_name ('f') parameter
with trailing '/'... I guessed wrong.
By the way, we should fix error when we try to "tree" display blob, or
"blob" display tree.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-21 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 7:48 [PATCH] gitweb: fix display of trees via PATH_INFO Martin Waitz
2006-09-21 8:56 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).