git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix snapshot link in tree view
@ 2006-09-22 23:21 Petr Baudis
  2006-09-23  0:44 ` Junio C Hamano
  2006-09-23  9:01 ` Jakub Narebski
  0 siblings, 2 replies; 4+ messages in thread
From: Petr Baudis @ 2006-09-22 23:21 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

It would just give HEAD snapshot instead of one of the particular tree.

Perhaps we should also include snapshot in the global navbar? And perhaps
stgit should have a way to edit the mail before sending it so that I could
note this below the three dashes? ;-)

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c5f3810..fc31ac3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2771,7 +2771,7 @@ sub git_tree {
 		if ($have_snapshot) {
 			# FIXME: Should be available when we have no hash base as well.
 			push @views_nav,
-				$cgi->a({-href => href(action=>"snapshot")},
+				$cgi->a({-href => href(action=>"snapshot", hash=>$hash)},
 					"snapshot");
 		}
 		git_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix snapshot link in tree view
  2006-09-22 23:21 [PATCH] Fix snapshot link in tree view Petr Baudis
@ 2006-09-23  0:44 ` Junio C Hamano
  2006-09-23  9:01 ` Jakub Narebski
  1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2006-09-23  0:44 UTC (permalink / raw)
  To: Petr Baudis; +Cc: git

Petr Baudis <pasky@suse.cz> writes:

> It would just give HEAD snapshot instead of one of the particular tree.
>
> Perhaps we should also include snapshot in the global navbar? And perhaps
> stgit should have a way to edit the mail before sending it so that I could
> note this below the three dashes? ;-)

Personally, I do not mind having the first "Perhaps" in the log
message.

Will apply.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix snapshot link in tree view
  2006-09-22 23:21 [PATCH] Fix snapshot link in tree view Petr Baudis
  2006-09-23  0:44 ` Junio C Hamano
@ 2006-09-23  9:01 ` Jakub Narebski
  2006-09-23 12:16   ` Petr Baudis
  1 sibling, 1 reply; 4+ messages in thread
From: Jakub Narebski @ 2006-09-23  9:01 UTC (permalink / raw)
  To: git

By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would
make this patch easier to read as gitweb patch.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix snapshot link in tree view
  2006-09-23  9:01 ` Jakub Narebski
@ 2006-09-23 12:16   ` Petr Baudis
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Baudis @ 2006-09-23 12:16 UTC (permalink / raw)
  To: Jakub Narebski; +Cc: git

Dear diary, on Sat, Sep 23, 2006 at 11:01:15AM CEST, I got a letter
where Jakub Narebski <jnareb@gmail.com> said that...
> By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would
> make this patch easier to read as gitweb patch.

Sorry, I try to mark those patches as gitweb but sometimes I forget. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-09-23 12:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-22 23:21 [PATCH] Fix snapshot link in tree view Petr Baudis
2006-09-23  0:44 ` Junio C Hamano
2006-09-23  9:01 ` Jakub Narebski
2006-09-23 12:16   ` Petr Baudis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).