Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.

[Robin Rosenberg <robin.rosenberg@dewire.com>]

lördag 23 september 2006 06:17 skrev Junio C Hamano:
> Robin Rosenberg <robin.rosenberg@dewire.com> writes:
> > Binary files are except to this so far.
>
> Funny.  This works on my home machine (CVS 1.12.13) while it
> does not pass test #2 "with spaces" on another machine that has
> CVS 1.11.22.
That must be something else. I've tried with various cvs versions here 
(including plain 1.11.22) on Mandriva and SLES and it works on all with the 
lastest git on master (and 1.4.2.1). 

Could you give me some more info, like the output from -v on the failing 
machine and your perl and patch version numbers and locale? I'm just guessing 
what could matter here.  

Why patch? Well this patch works around (i.e. not perfect) a mismatch between 
what patch eats and git submits. They are not totally, compatible, and I'm 
not sure who to blame yet.  git emits diff's without timestamps, and what 
matters to patch, without a TAB before the file timestamp. When patch sees a 
header like "+++ filename with spaces.txt" it patches "filename". When it 
sees "+++ filename with spaces.txt<TAB>" if patches "filename with 
spaces.txt". The real fix would ofcourse be in git diff or patch sometime in 
the future.

> > +. ./test-lib.sh
> > +
> > +export CVSROOT=$(dirname $(pwd))/cvsroot
> > +export CVSWORK=$(dirname $(pwd))/cvswork
acknowledged

> You are creating t/{cvsroot,cvswork} directories.  Do not
> contaminate outside the test/trash directory your tests is
> started in.
>
> > +rm -rf $CVSROOT $CVSWORK
>
> People's $(pwd) can contain shell $IFS characters, especially on
> Cygwin.   Be careful and quote them when in doubt.

Considering this is a patch that should improve on whitespace handlung... ok. 
I'll resubmit later.

-- robin