From: Petr Baudis <pasky@suse.cz>
To: git@vger.kernel.org, 387515@bugs.debian.org
Subject: Re: cg-commit -p -m ignores -p
Date: Sun, 24 Sep 2006 19:48:37 +0200 [thread overview]
Message-ID: <20060924174837.GX20017@pasky.or.cz> (raw)
In-Reply-To: <20060915132319.12117.qmail@7d60384c102e6d.315fe32.mid.smarden.org>
Dear diary, on Fri, Sep 15, 2006 at 03:23:19PM CEST, I got a letter
where Gerrit Pape <pape@smarden.org> said that...
> Hi, please see http:/bugs.debian.org/387515 or below. I agree that
> ideally cg-commit should behave differently.
>
> Thanks, Gerrit.
>
> ----- Forwarded message from Andrew Suffield <asuffield@suffields.me.uk> -----
>
> cg-commit -p -m ignores the -p argument and silently commits. Yes,
> this is documented, but it's still stupid behaviour; if the user had
> meant that, they would have just used -m alone.
>
> At the very least, it should abort with an error (on the basis that
> the command makes no sense); more sensibly, it should create a log
> message with the given string and then spawn an editor (and then since
> the user will probably exit without changing the file, the "Abort or
> commit?" message would appear as per usual, which seems to me to be
> appropriate behaviour).
>
>
> ----- End forwarded message -----
Thanks, fixed by making cg-commit -p imply -e.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
prev parent reply other threads:[~2006-09-24 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 13:23 cg-commit -p -m ignores -p Gerrit Pape
2006-09-24 17:48 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060924174837.GX20017@pasky.or.cz \
--to=pasky@suse.cz \
--cc=387515@bugs.debian.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox