Git development
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: fsck objects and timestamp ordering
Date: Mon, 25 Sep 2006 12:40:04 -0400	[thread overview]
Message-ID: <20060925164004.GB27043@spearce.org> (raw)
In-Reply-To: <9e4733910609250932r146fea7alaaf858a18a8b50b0@mail.gmail.com>

Jon Smirl <jonsmirl@gmail.com> wrote:
> When running fsck objects, does it verify that timestamps are ordered
> in the same order as the dependency chains?

No and it can't.  Clock skew between systems could be several
minutes to several hours which means you may have earlier commits
building onto later commits.

The better place to check this (although we don't today) is in
git-commit-tree.  If the new commit's committer timestamp is older
than any of its parent's committer timestamps git-commit-tree
should probably at least issue a warning that there's a possible
timestamp problem on either this system or the system that created
one of those parent commits.

If the committer has a problem with that timestamp issue they could
address it and ammend the commit before the error propagates.
 
> I am having trouble with a CVS repository where the timestamp ordering
> and dependency order are in conflict. It would be best if git didn't
> experience the same problem.

It would be best if Git didn't experience a lot of the weird stuff
people were able to do to their CVS repositories.  Fortunately the
friendly folks on this mailing list have put the better part of a
year and a half into doing just that.  :)

-- 
Shawn.

  reply	other threads:[~2006-09-25 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-25 16:32 fsck objects and timestamp ordering Jon Smirl
2006-09-25 16:40 ` Shawn Pearce [this message]
2006-09-25 16:48   ` Shawn Pearce
2006-09-25 17:03 ` Linus Torvalds
2006-09-25 17:39   ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060925164004.GB27043@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=jonsmirl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox