* [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.
@ 2006-09-27 15:18 Shawn Pearce
2006-09-27 19:43 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Pearce @ 2006-09-27 15:18 UTC (permalink / raw)
To: git
This test should be testing update-index --add, not git-add as these
are two completely different implementations of what is essentially
the same task.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
t/t3700-add.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index d36f22d..c20e4c2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -35,7 +35,7 @@ test_expect_success \
'git repo-config core.filemode 0 &&
echo foo >xfoo2 &&
chmod 755 xfoo2 &&
- git-add xfoo2 &&
+ git-update-index --add xfoo2 &&
case "`git-ls-files --stage xfoo2`" in
100644" "*xfoo2) echo ok;;
*) echo fail; git-ls-files --stage xfoo2; exit 1;;
--
1.4.2.1.g1e40
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.
2006-09-27 15:18 [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case Shawn Pearce
@ 2006-09-27 19:43 ` Junio C Hamano
2006-09-27 19:51 ` Shawn Pearce
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-09-27 19:43 UTC (permalink / raw)
To: Shawn Pearce; +Cc: git
Shawn Pearce <spearce@spearce.org> writes:
> This test should be testing update-index --add, not git-add as these
> are two completely different implementations of what is essentially
> the same task.
Thanks -- I'd rephrase the last sentence, though.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.
2006-09-27 19:43 ` Junio C Hamano
@ 2006-09-27 19:51 ` Shawn Pearce
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Pearce @ 2006-09-27 19:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano <junkio@cox.net> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>
> > This test should be testing update-index --add, not git-add as these
> > are two completely different implementations of what is essentially
> > the same task.
>
> Thanks -- I'd rephrase the last sentence, though.
-- >8 --
Corrected copy-and-paste thinko in ignore executable bit test case.
This test should be testing update-index --add, not git-add to
ensure all possible interfaces behave the same way.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
t/t3700-add.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index d36f22d..c20e4c2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -35,7 +35,7 @@ test_expect_success \
'git repo-config core.filemode 0 &&
echo foo >xfoo2 &&
chmod 755 xfoo2 &&
- git-add xfoo2 &&
+ git-update-index --add xfoo2 &&
case "`git-ls-files --stage xfoo2`" in
100644" "*xfoo2) echo ok;;
*) echo fail; git-ls-files --stage xfoo2; exit 1;;
--
1.4.2.1.g1e40
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-27 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-27 15:18 [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case Shawn Pearce
2006-09-27 19:43 ` Junio C Hamano
2006-09-27 19:51 ` Shawn Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).