From: Luben Tuikov <ltuikov@yahoo.com>
To: git@vger.kernel.org
Subject: gitweb: using quotemeta
Date: Thu, 28 Sep 2006 14:15:59 -0700 (PDT) [thread overview]
Message-ID: <20060928211600.97412.qmail@web31808.mail.mud.yahoo.com> (raw)
Commit ab41dfbfd4f3f9fedac71550027e9813b11abe3d introduces
the use of quotemeta to quote the $filename of the snapshot.
The commit message explains:
Just in case filename contains end of line character.
But quotemeta quotes any characters not matching /A-Za-z_0-9/.
Which means that we get strings like this:
linux\-2\.6\.git\-5c2d97cb31fb77981797fec46230ca005b865799\.tar\.gz
Is this the desired behavior? FWIW, the backslash character
is not part of of the name, but ended up when the snapshot was written
to the filesystem.
Thanks,
Luben
next reply other threads:[~2006-09-28 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 21:15 Luben Tuikov [this message]
2006-09-28 23:18 ` gitweb: using quotemeta Junio C Hamano
2006-09-28 23:27 ` Luben Tuikov
2006-10-02 0:28 ` Jakub Narebski
2006-10-02 20:12 ` Luben Tuikov
2006-10-02 20:50 ` Jakub Narebski
2006-10-03 6:30 ` Junio C Hamano
2006-10-06 12:38 ` Jakub Narebski
2006-10-07 5:08 ` Junio C Hamano
2006-10-07 9:23 ` Jakub Narebski
2006-10-07 17:41 ` Luben Tuikov
2006-10-11 9:48 ` Jakub Narebski
2006-10-06 13:50 ` Petr Baudis
2006-10-06 18:21 ` Luben Tuikov
2006-10-06 18:45 ` Petr Baudis
-- strict thread matches above, loose matches on Subject: below --
2006-10-06 18:24 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928211600.97412.qmail@web31808.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).