Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.

[Robin Rosenberg <robin.rosenberg@dewire.com>]

fredag 29 september 2006 08:37 skrev Junio C Hamano:
> Please do not do more than one patch per e-mail; I'll have to
> save the attachment in separate files and manually make commits,
> which is more work.
>
> The build procedure for the release to build rpms runs testsuite
> as part of it, so I need to think a bit how to proceed with this
> patch.  Leaving the test failing on FC5 means I won't be able to
> cut binary releases.  Checking early in the test script to see
> if "patch" can grok a diff for a file with whitespaces, and
> skipping the whitespace test if we have a bad "patch", seems to
> the best workaround.
>
> BTW, the addition of TAB to the patch tail is done by "git diff"
> automatically for files with whitespace in them in the proposed
> updates version in "pu" (and it is done conditionally only for
> files whose names have whitespace), so I think your fix will
> become redundant when it graduates to "master".

But, then I can stop here, because that sounds like a much better solution. My
hack is kind-of-kludgy anyway. I'll look in the pu branch. Still want the test 
cases, although not complete?

-- robin